Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Translation] Remove TranslatorBagInterface to allow for optimized caching in 3.0#14530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Uh oh!
There was an error while loading.Please reload this page.
Closed
Changes from1 commit
Commits
Show all changes
14 commits Select commitHold shift + click to select a range
65962c3
Add FallbackLocaleAwareInterface to obtain the locale actually used f…
mpdude2688b09
Keep test methods around as long as we still implement the interface
mpdude3077d80
Add note for future me.
mpdudefa055ec
For BC, use an adapter class to implement FallbackLocaleAwareInterfac…
mpdudee4bba37
Add deprecation notices to docblocks
mpdude372c247
Avoid unnecessary code change
mpdude98b1a74
use strict comparison
mpdude89df6f5
Use `if` instead of `elseif` because the `if` returns
mpdude24f0830
Update legacy tests
mpdude1364559
Improve deprecation notice
mpdudec0f6bf0
Improve docblock
mpdude4df5021
Fabbot
mpdude2a72a09
We must not require clients to implement a deprecated interface
mpdudead53737
Typo pointed out by FabBot
mpdudeFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Improve docblock
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commitc0f6bf02ebef9dcc9439409d4ec759ecdc0ad52e
There are no files selected for viewing
5 changes: 4 additions & 1 deletionsrc/Symfony/Component/Translation/Translator.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.