NotificationsYou must be signed in to change notification settings
Fork9.6k
Star30.4k

[2.8][Translation] added message cache.#14526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

aitboudad wants to merge1 commit intosymfony:2.8fromaitboudad:translation_message_cache

Closed

[2.8][Translation] added message cache.#14526

aitboudad wants to merge1 commit intosymfony:2.8fromaitboudad:translation_message_cache

Conversation

Copy link

Contributor

aitboudad commentedMay 3, 2015

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Fixed tickets	#13676
Tests pass?	yes
License	MIT

# app/config/config.ymlframework:translator:cache:translation.cache.default

The message cache Interface contains now only one method:

interface MessageCacheInterface{publicfunctioncache($locale,array$options =array());}

for more details see#13986.

aitboudad added the Translation label

May 3, 2015

aitboudad mentioned this pull request

May 3, 2015

[2.7][Translation] added message cache.#13986

Closed

2 tasks

aitboudad force-pushed thetranslation_message_cache branch 2 times, most recently fromcf5dd74 tocc6556dCompare

May 3, 2015 00:53

pborreli reviewed

May 3, 2015

View reviewed changes

src/Symfony/Component/Translation/MessageCache.php

		use Symfony\Component\Config\ConfigCacheFactory;

		/**
		* @author Abdellatif Ait Boudad <a.aitboudad@gmail.com>

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

boudad is lowercase 😆

Copy link

ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

😴

Copy link

ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

fixed thanks

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

on his own last name nice@pborreli

[Translation] added message cache.

3d1a39f

aitboudad force-pushed thetranslation_message_cache branch fromcc6556d to3d1a39fCompare

May 3, 2015 00:59

Copy link

Contributor

mpdude commentedMay 3, 2015

Why do you think do we need another interface for this and make theTranslator aware of it?

I mean, why can't we just decorate theTranslator with a caching layer that keeps the results oftrans() andtransChoice() in (shared) memory?

Copy link

ContributorAuthor

aitboudad commentedMay 3, 2015

@mpdude The current implementation try to simplify theTranslator itself and to not be aware of how to caching and also it provide the consistant way to overrideMessageCatalogue.
Decorating solve the issue but it isn't ideal as it's attempt to not calltrans() andtransChoice() of theTranslator which can make hard to handle other decorated class likeLoggingTranslator orDataCollectorTranslator for example.