Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Form] Added ability to clear form errors#14233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
dosten commentedApr 6, 2015
I think this can be added to 2.7 without problems. |
colinodell commentedApr 6, 2015
@dosten I was thinking it's a BC break because it adds a new method to an interface; any existing code implementing that interface would break unless they implemented this method. |
colinodell commentedApr 6, 2015
Travis seems to be failing some builds but I think my unit tests are passing. |
dosten commentedApr 6, 2015
@colinodell Following the BC promise (http://symfony.com/doc/current/contributing/code/bc.html#changing-interfaces) and as of the |
wouterj commentedApr 6, 2015
@dosten: with some problems, check footnote 2:
|
colinodell commentedApr 7, 2015
The required tests now pass after rebasing onto the latest I'd prefer to keep this targeted for 3.0/master unless a core dev advises otherwise. (The BC-break could be avoiding by delaying the interface change until 3.0, but then you'd have to check |
stof commentedApr 7, 2015
I'm not a fan of adding this method in the FormInterface. It is here for a very specific use case, and this one can already be solved in different ways IMO:#14060 |
webmozart commentedJun 19, 2015
Closing since the original ticket was closed as well:#14060 |
mcorteel commentedDec 15, 2017
It was reopened by@fabpot a few days ago though! |
TerjeBr commentedJun 7, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@webmozart could you please reopen this? #14060 has been reopened, and it would be good to have this as an open PR to go with it. |
xabbuh commentedJun 7, 2018
FYI, we cannot reopen the PR as the repository this was based on has been deleted in the meantime. |
This PR was squashed before being merged into the 4.2-dev branch (closes#27580).Discussion----------[Form] Add ability to clear form errors| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#14060| License | MIT| Doc PR |symfony/symfony-docs#9916This PR adds the ability to manually clear form errors, thus improving the DX issue reported in#14060.Unlike my original approach in#14233 and#27571 which break BC, this adds a new `ClearableErrorInterface` which `Form` implements. (`Button` does not implement it because buttons can't have errors.)Commits-------9eb755c [Form] Add ability to clear form errors
* Travis seems to be failing some builds for an unrelated reason
TODO:
Summary:
This PR adds the ability to manually clear form errors, thus improving the DX issue reported in#14060.