Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Serializer] Supports hassers and setters for groups annotations#14187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dunglas merged 1 commit intosymfony:2.7fromdunglas:enhanced_groups
Apr 27, 2015

Conversation

@dunglas
Copy link
Member

QA
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketsn/a
LicenseMIT
Doc PRn/a

For more coherence with the newObjectNormalizer (#13257), this PR allows to add@Groups annotations on hasser and setter methods too.

@dunglas
Copy link
MemberAuthor

ping @symfony/deciders

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Why was this present before? Can it safely be removed?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It's safe, I've just moved them on other supported methods.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Don't you test "hasser" ?

@jakzal
Copy link
Contributor

looks good to me 👍

@aitboudad
Copy link
Contributor

👍

2 similar comments
@stloyd
Copy link
Contributor

👍

@xabbuh
Copy link
Member

👍

@dunglas
Copy link
MemberAuthor

Ok to merge it in 2.7?

@aitboudad
Copy link
Contributor

@dunglas#13505 (comment) :)

@dunglas
Copy link
MemberAuthor

@aitboudad I know that but it can be considered as part of the "serializer groups" and "object normalizer" feature and those features have been released with the beta ;)

I think it's better to have polished features in 2.7 stable and this is some polish.

@dunglas
Copy link
MemberAuthor

Btw the PR was open 8 days before the release of the beta.

@stloyd
Copy link
Contributor

IMO it's totally correct to have this in 2.7 as this is addition to new feature introduced in that version, so it's like "bugfix" ;)

@aitboudad
Copy link
Contributor

well I think this can be considered as a bugfix.
@dunglas Is there a use case for addingsetters supports ?

@dunglas
Copy link
MemberAuthor

@aitboudad it's a matter of taste but I think yes. In fact this PR is derived from a use case in a project I work on:

  • I have 2 groups: one for normalization, another for denormalization
  • I set my groups on interfaces trough annotations (so no property available)
  • I like to put my denormalization group definitions on setters, I think it's easier to find them as it's a mutation operation than when they are on a getter.

@dunglasdunglas merged commit9c87ecc intosymfony:2.7Apr 27, 2015
dunglas added a commit that referenced this pull requestApr 27, 2015
…nnotations (dunglas)This PR was merged into the 2.7 branch.Discussion----------[Serializer] Supports hassers and setters for groups annotations| Q             | A| ------------- | ---| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | n/a| License       | MIT| Doc PR        | n/aFor more coherence with the new `ObjectNormalizer` (#13257), this PR allows to add `@Groups` annotations on hasser and setter methods too.Commits-------9c87ecc [Serializer] Supports hassers and setters for groups annotations
@dunglasdunglas deleted the enhanced_groups branchDecember 5, 2015 09:02
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dunglas@jakzal@aitboudad@stloyd@xabbuh@dupuchba

[8]ページ先頭

©2009-2025 Movatter.jp