Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
Removed deprecations in Filesystem component#14145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
dosten commentedMar 31, 2015
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
| @@ -479,9 +477,6 @@ public function dumpFile($filename, $content, $mode = 0666) | |||
| } | |||
| $this->rename($tmpFile, $filename, true); | |||
| if (null !== $mode) { | |||
| $this->chmod($filename, $mode); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks like we missed triggering a deprecation notice here in 2.7?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes, you are right, in what branch must be applied a patch for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We add these to 2.7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The default value of the$mode param is 0666, so the error will be triggered ever
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
see#14460
can you also update the CHANGELOG. |
@aitboudad sorry i don't understand, update the CHANGELOG.md for what? |
@dosten just add note about the removed deprecations, you can seehttps://github.com/symfony/symfony/blob/master/src/Symfony/Component/Form/CHANGELOG.md for example |
@aitboudad Done! |
Thank you@dosten. |
This PR was squashed before being merged into the 3.0-dev branch (closes#14145).Discussion----------Removed deprecations in Filesystem component| Q | A| ------------- | ---| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -Commits-------5d1e558 Removed deprecations in Filesystem component