Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DependencyInjection] Improved yaml syntax#13892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
nicolas-grekas commentedMar 18, 2015
👍 |
Member
stof commentedMar 18, 2015
This implementatio currently supports mixing numeric keys and name keys for the method and the arguments, which can be confusing |
… in "calls" statement for yaml format
ContributorAuthor
hason commentedMar 18, 2015
@stof Fixed |
Member
fabpot commentedMar 19, 2015
Looks good to me 👍 |
Member
fabpot commentedMar 23, 2015
@hason Can you make a PR on the docs to document this new possibility? Thanks. |
Member
fabpot commentedMar 23, 2015
Thank you@hason. |
fabpot added a commit that referenced this pull requestMar 23, 2015
This PR was merged into the 2.7 branch.Discussion----------[DependencyInjection] Improved yaml syntax| Q | A| ------------- | ---| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |This PR adds support for this:```yamlservices: manager: class: UserManager arguments: - true calls: - method: setLogger arguments: -@logger - method: setClass arguments: - User tags: - name: manager alias: user```Commits-------0eb34f3 [DependencyInjection] Added support for keys "method" and "arguments" in "calls" statement for yaml format
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for this: