NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

Enforce UTF-8 charset for core controllers#13715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:2.3fromwouterj:issue_7532

Feb 24, 2015

Merged

Enforce UTF-8 charset for core controllers#13715

fabpot merged 1 commit intosymfony:2.3fromwouterj:issue_7532

Feb 24, 2015

Conversation

Copy link

Member

wouterj commentedFeb 17, 2015

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#7532
License	MIT
Doc PR	-

See#7617 and#7532 for the context of this PR.

wouterj force-pushed theissue_7532 branch from5a37829 to1db9cf5Compare

February 17, 2015 12:53

Copy link

Member

nicolas-grekas commentedFeb 17, 2015

👍

Copy link

Member

nicolas-grekas commentedFeb 17, 2015

Maybe a few assertions added ProfilerControllerTest could help prevent breaking the fix

Copy link

Member

GromNaN commentedFeb 18, 2015

You can use the syntax Response::create() to chain the setCharset.

wouterj force-pushed theissue_7532 branch from1db9cf5 to80cafceCompare

February 19, 2015 22:11

Copy link

MemberAuthor

Thanks for the great suggestions,@nicolas-grekas and@GromNaN! I've now updated the PR to useRequest::create() and I've added an assertion to theProfilerControllerTest andExceptionControllerTest.

javiereguiluz reviewed

Feb 20, 2015

View reviewed changes

src/Symfony/Bundle/TwigBundle/Tests/Controller/ExceptionControllerTest.php Outdated

Copy link

Member

javiereguiluzFeb 20, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

typo:explicitely ->explicitly

Enforce UTF-8 charset for core controllers

3032014

wouterj force-pushed theissue_7532 branch from80cafce to3032014Compare

February 20, 2015 10:19

Copy link

MemberAuthor

wouterj commentedFeb 20, 2015

Fixed the typos

Copy link

Member

fabpot commentedFeb 24, 2015

Thank you@wouterj.

fabpot merged commit3032014 intosymfony:2.3

Feb 24, 2015

fabpot added a commit that referenced this pull request

Feb 24, 2015

bug#13715Enforce UTF-8 charset for core controllers (WouterJ)

463b24b

This PR was merged into the 2.3 branch.Discussion----------Enforce UTF-8 charset for core controllers| Q             | A| ------------- | ---| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#7532| License       | MIT| Doc PR        | -See#7617 and#7532 for the context of this PR.Commits-------3032014 Enforce UTF-8 charset for core controllers

wouterj deleted the issue_7532 branch

February 24, 2015 11:54

wouterj mentioned this pull request

Feb 24, 2015

Kernel charset, twig charset and templates encoding#7617

Closed

nicolas-grekas added a commit to nicolas-grekas/symfony that referenced this pull request

Mar 11, 2015

Revert "bugsymfony#13715Enforce UTF-8 charset for core controllers …

6ca7fc9

…(WouterJ)"This reverts commit463b24b, reversingchanges made toc475704.

nicolas-grekas mentioned this pull request

Mar 11, 2015

[Bundle] Fix charset config#13901

Merged

fabpot added a commit that referenced this pull request

Mar 12, 2015

bug#13901[Bundle] Fix charset config (nicolas-grekas, bamarni)

374b718

This PR was merged into the 2.3 branch.Discussion----------[Bundle] Fix charset config| Q             | A| ------------- | ---| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#13715,#7617,#7532| License       | MIT| Doc PR        | -This reverts#13715 and resurrects#7532, which was fine.Commits-------ef41059 [WebProfilerBundle] Set debug+charset on the ExceptionHandler fallbackcbd0525 used HTML5 meta charset tag and removed hardcoded ones6ca7fc9 Revert "bug#13715 Enforce UTF-8 charset for core controllers (WouterJ)"

fabpot added a commit that referenced this pull request

Mar 12, 2015

Merge branch '2.3' into 2.6

43efb1a

* 2.3:  [HttpFoundation] MongoDbSessionHandler::read() now checks for valid session age  [WebProfilerBundle] Set debug+charset on the ExceptionHandler fallback  used HTML5 meta charset tag and removed hardcoded ones  Revert "bug#13715 Enforce UTF-8 charset for core controllers (WouterJ)"Conflicts:src/Symfony/Bundle/TwigBundle/Controller/ExceptionController.phpsrc/Symfony/Bundle/WebProfilerBundle/Controller/ProfilerController.phpsrc/Symfony/Component/HttpFoundation/Session/Storage/Handler/MongoDbSessionHandler.phpsrc/Symfony/Component/HttpFoundation/Tests/Session/Storage/Handler/MongoDbSessionHandlerTest.php

fabpot added a commit that referenced this pull request

Mar 12, 2015

Merge branch '2.6' into 2.7

6d605a7

* 2.6:  [HttpFoundation] MongoDbSessionHandler::read() now checks for valid session age  Changed visibility of setUp() and tearDown to protected  [WebProfilerBundle] Set debug+charset on the ExceptionHandler fallback  Added default button class  used HTML5 meta charset tag and removed hardcoded ones  Revert "bug#13715 Enforce UTF-8 charset for core controllers (WouterJ)"  fixed XSS in the exception handler  Php Inspections (EA Extended) - static code analysis includes:  [2.3] Remove most refs uses  Test with local components instead of waiting for the subtree-splitter when possibleConflicts:.travis.yml

nicolas-grekas added a commit that referenced this pull request

Mar 13, 2015

Merge branch '2.7'

21450da

* 2.7:  Changed visibility of setUp() and tearDown to protected  Changed visibility of setUp() and tearDown to protected  [2.7] Fix travis file  [HttpFoundation] MongoDbSessionHandler::read() now checks for valid session age  [Debug] reintroduce charset param to ExceptionHandler  Changed visibility of setUp() and tearDown to protected  [WebProfilerBundle] Set debug+charset on the ExceptionHandler fallback  [Debug] deprecate ExceptionHandler::utf8Htmlize  Added default button class  used HTML5 meta charset tag and removed hardcoded ones  Revert "bug#13715 Enforce UTF-8 charset for core controllers (WouterJ)"  fixed XSS in the exception handler  Php Inspections (EA Extended) - static code analysis includes:  [2.3] Remove most refs uses  [FrameworkBundle] Read config/validation/*.(xml|yml) files  Test with local components instead of waiting for the subtree-splitter when possibleConflicts:src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Compiler/LegacyTemplatingAssetHelperPassTest.phpsrc/Symfony/Bundle/TwigBundle/Tests/Extension/LegacyAssetsExtensionTest.phpsrc/Symfony/Bundle/TwigBundle/Tests/TokenParser/LegacyRenderTokenParserTest.phpsrc/Symfony/Component/ClassLoader/Tests/LegacyUniversalClassLoaderTest.phpsrc/Symfony/Component/Console/Helper/ProgressHelper.phpsrc/Symfony/Component/Console/Tests/Helper/LegacyDialogHelperTest.phpsrc/Symfony/Component/Console/Tests/Helper/LegacyProgressHelperTest.phpsrc/Symfony/Component/Debug/ExceptionHandler.phpsrc/Symfony/Component/HttpFoundation/Tests/Session/Storage/Handler/MongoDbSessionHandlerTest.phpsrc/Symfony/Component/Routing/Tests/Matcher/Dumper/LegacyApacheMatcherDumperTest.phpsrc/Symfony/Component/Templating/Tests/Helper/LegacyAssetsHelperTest.php