After investigating more on how I hit this corner case, I have more information.
I have a form with 2 fields integer fields. I'm submitting a GET request with 1 field only and forcing$clearMissing = true, which will then call$form->submit() for the second field withNULL data.
When it requires to fetchempty_data, it retrieves the integer value, but theviewToNorm transformation fails because it expects a string.
That's how I think I hit this very interesting weird corner case. =)

Definitely needs tests

Also see#5939
What you probably need is a string in view data via'empty_data' => '1'

@Tobion I completely understand that quoted value leads to proper response. That's what I'm using internally in address this issue.
However, this patch introduces the same behavior as$submittedData, which means that likely some of the previously reported issues would be addressed by this patch. Please understand that currentlyempty_data option exposes itself supporting mixed values.http://symfony.com/doc/current/reference/forms/types/integer.html#empty-data

In any case, this cannot be accepted without tests

@guilhermeblanco Any chance you can add some tests?

@fabpot I need to remember the situation that I hit it, but yes, I can add tests for this. =)
IIRC it's due to the fact that empty_data must be an string to work, otherwise it sets the form value to null. According to the docs, it's supposed to support mixed.
I'll double check and add tests for this. =)

Thank you for submitting this PR@guilhermeblanco! This is a duplicate of#12470. The underlying problem here is#4715, which can't be fixed without breaking BC. Every other solution is unfortunately a hack. I recommend that you use a custom model transformer that sets your default value instead until#4715 is fixed.

@webmozart Yes, it is a duplicate. However, can you explain me how does this solution qualify as a BC break?
Currently, it is the same approach taken a few lines beforehttps://github.com/symfony/symfony/blob/2.8/src/Symfony/Component/Form/Form.php#L535 and there's no way to get non-string values to work. The only BC I can realize here is a not working situation to a working situation.

Reopened after talking to@guilhermeblanco in person. This solution makes sense. Could you please rebase this on 2.3 and add tests?

@guilhermeblanco Any news on this one?

@fabpot should be able to do it in the next few days. =)

@guilhermeblanco Sorry for being pushy, but we try hard to merge/close old PRs. Any chance you can have a look at this one?

@fabpot I've spent a substantial amount of hours trying to recreate this scenario on both SimpleFormTest and CompoundFormTest without success.
The issue is however easily reproducible if followed the steps I detailed in the ticket and first comment. Feel free to close if you think appropriate, but this patch solves the bug in my app.

I've tried to add tests inIntegerTypeTest but phpunit skip them... I don't understand.

Here's what I've tried :

publicfunctiontestSubmitNull(){$form =$this->factory->create('integer');$form->submit(null);$this->assertNull($form->getData());$this->assertNull($form->getViewData());}publicfunctiontestSubmitNullWithEmptyData(){$form =$this->factory->create('integer',null,array('empty_data' =>1,    ));$form->submit(null);$this->assertSame(1,$form->getData());$this->assertSame('1',$form->getViewData());}publicfunctiontestSubmitNullWithEmptyDataWhenNested(){$form =$this->factory->create('form')        ->add('age','integer',array('empty_data' =>1,        ));$form->submit(null);$this->assertSame(1,$form->get('age')->getData());$this->assertSame('1',$form->get('age')->getViewData());}

@HeahDude IntegerTypeTest requires the intl extension (have a look at the setUp() method).

@jakzal thanks, will take another look though.

@jakzal, I've checked and I have intl installed, but tests are skipped even with my global phpunit.

Any lead ?

@HeahDude if I remember correctly it needs to be installed in a specific version. You'll need to look into the code that makes the check.

@HeahDude PHPUnit tells you why a test was skipped if you pass the-v option. In this particular case, the test is skipped because it requires the intl extension with ICU in version 52.1 to be installed. However, current PHP versions ship with ICU 55.1, which is why the tests are being skipped.

#14260 proposes to upgrade to ICU 55.1, which would solve your problem. Would you like to work on that ticket?

IIUC, the change is good but we don't know (yet) how to write good unit tests to avoid regressions, is that correct?

@fabpot correct. Patch addresses nicely the problem in the known scenario: 2 integer fields with empty_data as integer values and submitting only one of the values (thus requiring the second to use the empty_data).
The patch also uses the same solution for submitted data conversion already in codebase (https://github.com/symfony/symfony/blob/2.3/src/Symfony/Component/Form/Form.php#L532 ), but in the context of empty data (which means when submitted data is not present).

Understood. So, instead of waiting for tests, and because this is a bug fix that is waiting here for so long, I propose to merge this as is for now. ping @symfony/deciders

@fabpot I'll talk to@guilhermeblanco and try to create some tests. If we don't, chances are that this gets refactored away again when optimizing theForm class.

@guilhermeblanco, is the form compound in your scenario ? I think it may be either not relevant or some cause of this problem.

I'm fine to have this merged - as long as we don't have any BC concerns. If this introduces an edge-case behavior change, I'm not clearwhat that change is - I'd like to see the before/after code in an UPGRADE file. I want to avoid this causing upgrade issues - it sounds like something that would be quite hard to track down.

I took@guilhermeblanco's commit and the tests suggested by@HeahDude (with a minor change where the view data are not expected to benull but the empty string instead) to finish this PR in#18047. I can confirm that the tests were failing before this change and that they do pass now. Should add a special test for the checkbox type too (as the issue initially talked about checkboxes)? And how would such a test look like?

Nice job! I would suggest:

// CheckBoxTypeTest.phppublicfunctiontestSubmitNullWithEmptyDataTrueWhenNested(){$form =$this->factory->create('form')        ->add('agree','checkbox',array('empty_data' =>true,        ));$form->submit(null);$this->assertTrue($form->get('agree')->getData());$this->assertSame('1',$form->get('agree')->getViewData());$view =$form->get('agree')->createView();$this->assertTrue($view->vars['checked']);}publicfunctiontestSubmitNullWithEmptyDataFalseWhenNested(){$form =$this->factory->create('form')        ->add('agree','checkbox',array('empty_data' =>false,        ));$form->submit(null);$this->assertFalse($form->get('agree')->getData());$this->assertEmpty($form->get('agree')->getViewData());$view =$form->get('agree')->createView();$this->assertFalse($view->vars['checked']);}

And I confirm those tests fail without the fix.

@HeahDude Thanks, test added.

Closed for the reasons discussed in#18047.