Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DependencyInjection] make dumping inlined configurators to XML possible#13557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedJan 30, 2015
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
a39c494 toa9b66adComparexabbuh commentedMar 16, 2015
If this is considered a new feature, it should be discussed whether or not it can make it into Symfony 2.7. And we could then also think about a similar way for inlining service factories (see#13913). |
fabpot commentedMar 19, 2015
Looks good to me. Adding something similar for service factories would be event better (can you add this to this PR as well?). We still have time for including this in 2.7, so let's try to make it happen. |
xabbuh commentedMar 19, 2015
Thanks for the feedback. I think I can do something like this for the factories here too until the end of the week. |
fabpot commentedMar 23, 2015
... last week to make it available in 2.7 :) |
xabbuh commentedMar 23, 2015
@fabpot Can you please merge the |
fabpot commentedMar 23, 2015
@xabbuh done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
couldn't it reuse the<configurator> tag instead of using a different one ?
xabbuh commentedMar 23, 2015
As@stof pointed out, the implementation was not completely correct and was also a bit too complicated. Also, these changes need to be based on the |
… services to XML (xabbuh)This PR was merged into the 2.7 branch.Discussion----------[DependencyInjection] make it possible to dump inlined services to XML| Q | A| ------------- | ---| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#13557| License | MIT| Doc PR |Commits-------504e338 make it possible to dump inlined services to XML