Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[DependencyInjection] make dumping inlined configurators to XML possible#13557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
xabbuh wants to merge1 commit intosymfony:2.5fromxabbuh:inlined-configurators

Conversation

@xabbuh
Copy link
Member

QA
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets
LicenseMIT
Doc PR

@xabbuh
Copy link
MemberAuthor

If this is considered a new feature, it should be discussed whether or not it can make it into Symfony 2.7. And we could then also think about a similar way for inlining service factories (see#13913).

@fabpot
Copy link
Member

Looks good to me. Adding something similar for service factories would be event better (can you add this to this PR as well?).

We still have time for including this in 2.7, so let's try to make it happen.

@xabbuh
Copy link
MemberAuthor

Thanks for the feedback. I think I can do something like this for the factories here too until the end of the week.

@fabpot
Copy link
Member

... last week to make it available in 2.7 :)

@xabbuh
Copy link
MemberAuthor

@fabpot Can you please merge the2.6 branch into2.7? I can then rebase my local changes to ensure that theInlineServiceDefinitionsPass will properly inline both configurators and factories again (probably need to do a new pull request for the right target branch then).

@fabpot
Copy link
Member

@xabbuh done

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

couldn't it reuse the<configurator> tag instead of using a different one ?

@xabbuh
Copy link
MemberAuthor

As@stof pointed out, the implementation was not completely correct and was also a bit too complicated. Also, these changes need to be based on the2.7 branch to properly put back the inlining of factory services as well as configurator services to theInlineServiceDefinitionsPass. Please see#14030 for the replacing pull request.

@xabbuhxabbuh closed thisMar 23, 2015
@xabbuhxabbuh deleted the inlined-configurators branchMarch 23, 2015 19:21
fabpot added a commit that referenced this pull requestMar 24, 2015
… services to XML (xabbuh)This PR was merged into the 2.7 branch.Discussion----------[DependencyInjection] make it possible to dump inlined services to XML| Q             | A| ------------- | ---| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#13557| License       | MIT| Doc PR        |Commits-------504e338 make it possible to dump inlined services to XML
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xabbuh@fabpot@stof

[8]ページ先頭

©2009-2025 Movatter.jp