Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DX] Attempt to improve logging messages with parameters#13418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What about moving the username as well (same below.) The more static the message is, the better for log aggregators.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I wasn't sure as in many cases the message would become borked. I agree that it would be a better solution.
Edit, I can leave the username in the messageand add it to the context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
"Basic authentication Authorization header found" is enough I think.
linaori commentedJan 15, 2015
@stof@fabpot I have processed the remarks. While at it, I want to add or remove the trailing |
linaori commentedJan 15, 2015
Seems like a flaky test is making this build fail: |
fabpot commentedJan 15, 2015
I would add dots everywhere (which is what we do for exception messages). |
linaori commentedJan 15, 2015
Dots added and tests updated. |
fabpot commentedJan 16, 2015
👍 |
fabpot commentedJan 16, 2015
Thank you@iltar. |
…n logging it. (Koc)This PR was merged into the 2.7 branch.Discussion----------[DX] Fixed regression when exception message swallowed when logging it.| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | maybe, wait for Travis| Fixed tickets | fixed regression introduced in#13418| License | MIT| Doc PR | -The problem is: after merging referenced PR we cann't understand what error occured and why authentication request failed (see attached screenshot). Previously it displays exception message, but now it only displays class of the exception.Commits-------042cb6b Fixed regression when exception message swallowed when logging it.
This PR is a follow-up of#12594
[DX] [HttpKernel] Use "context" argument when logging route in RouterListener.I have attempted to improve the log messages, as well as updating the usage context. I wasn't sure if the log messages should end with a
.or not, if so I can update all messages to confirm a standard.