Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[VarDumper] fix very special vars handling#13351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:2.6fromnicolas-grekas:fix-vardumper
Jan 13, 2015

Conversation

@nicolas-grekas
Copy link
Member

QA
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#13235
LicenseMIT
Doc PR-

@nicolas-grekasnicolas-grekas changed the titles[VarDumper] fix very special vars handling[VarDumper] fix very special vars handlingJan 9, 2015
@nicolas-grekasnicolas-grekasforce-pushed thefix-vardumper branch 2 times, most recently from40ef355 to5ee47daCompareJanuary 9, 2015 21:40
@nicolas-grekas
Copy link
MemberAuthor

PR is ready. Fabbot is drunk and Travis will be fixed after subtree-splitting (for what is concerned by this)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

should you check for the extension being loaded to avoid skipping in this case ?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

No, the extension does not help here, I'm going to update the message

@stof
Copy link
Member

stof commentedJan 9, 2015

AFAICT, the PHP-CS-Fixer expects the& to be near the variable name (or with spaces on both sides), not near the assignment operator, which is why it adds the space everywhere.

for the indentation change at the end, I'm quite sure it is a bug in the PHP-CS-Fixer logic to detect closures, which is not taking into account the possibility to return by reference. I submittedPHP-CS-Fixer/PHP-CS-Fixer#964

@stof
Copy link
Member

stof commentedJan 9, 2015

@fabpot what is actually the Symfony coding standard for the placement of the& for references ? PSR-2 does not talk about spaces around operators at all. Given that Symfony says to put spaces around operators, the PHP-CS-Fixer is enforcing the spaces. It has no special rule for the placement of references after the assignment operator, which is why it requires a space there as well. But is the fixer right for that ?

@nicolas-grekasnicolas-grekasforce-pushed thefix-vardumper branch 3 times, most recently from2308390 tof3b2fe0CompareJanuary 10, 2015 15:56
@keradus
Copy link
Member

It's aOperators should be arounded by at least one space. rule.
There is&= operator (T_AND_EQUAL), but no=&. It's in fact 2 operators.

@fabpot
Copy link
Member

Thank you@nicolas-grekas.

@fabpotfabpot merged commite26dc2c intosymfony:2.6Jan 13, 2015
fabpot added a commit that referenced this pull requestJan 13, 2015
This PR was merged into the 2.6 branch.Discussion----------[VarDumper] fix very special vars handling| Q             | A| ------------- | ---| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#13235| License       | MIT| Doc PR        | -Commits-------e26dc2c [VarDumper] fix very special vars handling
@nicolas-grekasnicolas-grekas deleted the fix-vardumper branchJanuary 13, 2015 14:51
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nicolas-grekas@stof@keradus@fabpot

[8]ページ先頭

©2009-2025 Movatter.jp