Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[VarDumper] fix very special vars handling#13351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedJan 9, 2015
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #13235 |
| License | MIT |
| Doc PR | - |
40ef355 to5ee47daComparenicolas-grekas commentedJan 9, 2015
PR is ready. Fabbot is drunk and Travis will be fixed after subtree-splitting (for what is concerned by this) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
should you check for the extension being loaded to avoid skipping in this case ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
No, the extension does not help here, I'm going to update the message
stof commentedJan 9, 2015
AFAICT, the PHP-CS-Fixer expects the for the indentation change at the end, I'm quite sure it is a bug in the PHP-CS-Fixer logic to detect closures, which is not taking into account the possibility to return by reference. I submittedPHP-CS-Fixer/PHP-CS-Fixer#964 |
stof commentedJan 9, 2015
@fabpot what is actually the Symfony coding standard for the placement of the |
2308390 tof3b2fe0Comparef3b2fe0 toe26dc2cComparekeradus commentedJan 11, 2015
It's a |
fabpot commentedJan 13, 2015
Thank you@nicolas-grekas. |
This PR was merged into the 2.6 branch.Discussion----------[VarDumper] fix very special vars handling| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#13235| License | MIT| Doc PR | -Commits-------e26dc2c [VarDumper] fix very special vars handling