Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpKernel][2.7] Add request uri to Logger context#13320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
please distinguish route params and request uri, i.e.array('route-params' => $parameters, 'request-uri' => $request->getUri())
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
#13418 tries to make context more consistent. So, can you renameroute-params toroute_parameters andrequest-uri torequest_uri? You can also inline the context instead of creating a temp var here. Thanks.
fabpot commentedJan 16, 2015
👍 after the minor renaming is done. |
rvanlaak commentedJan 16, 2015
Fixed@fabpot will try to squash all commits in one I've been looking for docs about logging and log parameter conventions, but couldn't find them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I would preferroute_parameters as mentioned in my previous comment.
stof commentedJan 16, 2015
👍 |
... so host info does not get lost in the logging. The current situation does not allow the user to determine at which host an error occured.| Q | A| ------------- | ---| Bug fix? | [no]| New feature? | [yes]| BC breaks? | [no]| Deprecations? | [no]| Tests pass? | [yes]| Fixed tickets || License | MIT| Doc PR |Fixed typoDistinguish route-params from request-uriUpdate context consistency... and inline the context variable.Rename `route_params` to `route_parameters`
rvanlaak commentedJan 16, 2015
Squashing all commits into one is done. Had to figure out PhpStorm 8.0.3 did not allow me to force a push,because the force option was missing. |
fabpot commentedJan 16, 2015
Thank you@rvanlaak. |
…vanlaak)This PR was merged into the 2.7 branch.Discussion----------[HttpKernel][2.7] Add request uri to Logger context... so host info does not get lost in the logging. The current situation does not allow the user, that receives a `Monolog` email for instance, to determine at which host an error occurred.| Q | A| ------------- | ---| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR | -Commits-------c8f1f19 [HttpKernel] Add request uri to Logger context
... so host info does not get lost in the logging. The current situation does not allow the user, that receives a
Monologemail for instance, to determine at which host an error occurred.