Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpKernel] deprecated ContainerAwareHttpKernel#13280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
4f59c57 to0c50301CompareMember
stof commentedJan 6, 2015
👍 |
fabpot added a commit that referenced this pull requestJan 6, 2015
This PR was merged into the 2.7 branch.Discussion----------[HttpKernel] deprecated ContainerAwareHttpKernel| Q | A| ------------- | ---| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | yes| Tests pass? | yes| Fixed tickets | n/a| License | MIT| Doc PR | n/aIn Symfony 3.0, the `request` scope will be removed as the `request` is not a service anymore. So, the `ContainerAwareHttpKernel` should be deprecated now as it won't be needed anymore in 3.0. I've moved the only line of code that is still relevant in `HttpKernel` directly.Note that I did not trigger a deprecation notice as the class is still used in Symfony 2.7.Commits-------0c50301 [HttpKernel] deprecated ContainerAwareHttpKernel
Member
xabbuh commentedMay 15, 2015
Shouldn't we trigger deprecation warnings for people using the class in their own code and suppress them when used in Symfony itself? |
Member
xabbuh commentedMay 17, 2015
I created a PR for the deprecation trigger. Let's discuss it in#14665. |
fabpot added a commit that referenced this pull requestMay 20, 2015
…e ContainerAwareHttpKernel (xabbuh)This PR was merged into the 2.7 branch.Discussion----------[HttpKernel] trigger a deprecation warning when using the ContainerAwareHttpKernel| Q | A| ------------- | ---| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#13280| License | MIT| Doc PR |I agree that we should not trigger the deprecation warning when the `ContainerAwareHttpKernel` is used in the framework code. However, developers using this class in their own code should receive a warning to be able to prepare their applications for Symfony 3.0.Commits-------030731a [HttpKernel] trigger a deprecation warning when using the ContainerAwareHttpKernel
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Symfony 3.0, the
requestscope will be removed as therequestis not a service anymore. So, theContainerAwareHttpKernelshould be deprecated now as it won't be needed anymore in 3.0. I've moved the only line of code that is still relevant inHttpKerneldirectly.Note that I did not trigger a deprecation notice as the class is still used in Symfony 2.7.