Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Serializer] Refactoring and object_to_populate support.#13252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
MemberAuthor
dunglas commentedJan 4, 2015
The Travis failure is strange but doesn't seem related with this PR. Any hint@nicolas-grekas? |
This was referencedJan 4, 2015
Member
fabpot commentedJan 6, 2015
👍 |
Member
fabpot commentedJan 7, 2015
Thank you@dunglas. |
fabpot added a commit that referenced this pull requestJan 7, 2015
…t. (dunglas)This PR was merged into the 2.7 branch.Discussion----------[Serializer] Refactoring and object_to_populate support.| Q | A| ------------- | ---| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| License | MIT| Doc PR | n/aThis PR is mainly a refactoring. It move up the common code of `PorpertyNormalizer` and `GetSetMethodNormalizer` into `AbstractNormalizer`.It also adds a news feature: the ability to use an existing object instance for denormalization:```php$dummy = new GetSetDummy();$dummy->setFoo('foo');$obj = $this->normalizer->denormalize( array('bar' => 'bar'), 'GetSetDummy', null, array('object_to_populate' => $dummy));// $obj and $dummy are references to the same object```Commits-------b5990be [Serializer] Refactoring and object_to_populate support.dunglas added a commit that referenced this pull requestMar 6, 2015
This PR was merged into the 2.7 branch.Discussion----------[Serializer] ObjectNormalizer| Q | A| ------------- | ---| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| License | MIT| Doc PR | not yet`PropertyAccessNormalizer` is a new normalizer leveraging the PropertyAccess Component. It is able to handle classes containing both public properties and properties only accessibles trough getters / setters / issers / hassers...As it extends `AbstractNormalizer`, it supports circular reference handling, name converters and existing object population.What do you think about making this new normalizer the default one as it's the most convenient to use and the most consistent with the behavior of other components.#13120,#13252 and#13255 need to be merged to make this PR working.Commits-------0050bbb [Serializer] Introduce ObjectNormalizer
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is mainly a refactoring. It move up the common code of
PorpertyNormalizerandGetSetMethodNormalizerintoAbstractNormalizer.It also adds a news feature: the ability to use an existing object instance for denormalization: