Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[3.0][Form] Removed depracted events PRE_BIND, BIND and POST_BIND#13122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
saro0h commentedDec 26, 2014
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | yes |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | ~ |
| License | MIT |
| Doc PR | ~ |
896f1ce toa430ff9Comparetimglabisch commentedDec 28, 2014
👍 |
| })); | ||
| $config = new FormConfigBuilder('name', null, $this->dispatcher); | ||
| $config->addEventListener(FormEvents::PRE_BIND, array($mock, 'preBind')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This test should not be removed. It should simply use the new constant (and changing the constant being used should be done in older branches actually)
83d00c9 tob2a93b0Compare| @@ -118,23 +118,23 @@ public function testDataIsInitializedFromSubmit() | |||
| $form->submit('foobar'); | |||
| } | |||
| // https://github.com/symfony/symfony/pull/7789 | |||
| // https://github.com/symfony/symfony/pull/7789 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this change is wrong
b2a93b0 toa7fe849CompareChanges have been made. |
Can you rebase to re-run the tests? |
6b1845d tocce7d94Comparecce7d94 to1cdb655CompareDone. The tests do not pass because of that:https://travis-ci.org/symfony/symfony/jobs/45787598#L2208 |
Thank you@saro0h. |
…d POST_BIND (saro0h)This PR was merged into the 3.0-dev branch.Discussion----------[3.0][Form] Removed depracted events PRE_BIND, BIND and POST_BIND| Q | A| ------------- | ---| Bug fix? | no| New feature? | no| BC breaks? | yes| Deprecations? | no| Tests pass? | yes| Fixed tickets | ~| License | MIT| Doc PR | ~Commits-------1cdb655 [Form] Removed depracted events PRE_BIND, BIND and POST_BIND