Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Fix failing tests after merge#12967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedDec 13, 2014
@nicolas-grekas This is basically the same as#12963. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ah, I didn't fix this in#12963.
nicolas-grekas commentedDec 13, 2014
I just cherry-picked your fix so that the combinaison of both fixes have a chance to make tests green |
xabbuh commentedDec 13, 2014
@nicolas-grekas Thanks, though that was not really necessary since you fixed it in the same way. I closed#12963 in the meantime. The question remains if we should also allow |
Symfony 2.5 and higher requires ocramius/proxy-manager 0.4.0 orhigher.
nicolas-grekas commentedDec 13, 2014
Just added ~1.0 (but not 2.0 since it's a dev branch) |
fabpot commentedDec 13, 2014
Thank you@nicolas-grekas. |
This PR was merged into the 2.5 branch.Discussion----------Fix failing tests after merge| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -https://github.com/symfony/symfony/pull/12967/files?w=1Commits-------9b96373 Fix failing tests after merge6638535 fix ocramius/proxy-manager dependency version
https://github.com/symfony/symfony/pull/12967/files?w=1