Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[WebProfilerBundle] Avoid missing method when using __invoke on a controller#12958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
javiereguiluz commentedDec 12, 2014
@thewilkybarkid thanks for your PR! I love these quick wins! By the way, your message ends abruptly, so it's been probably cut unintentionally:"This PR changes it to only include the method section/double dots if the method name is included. This does mean that there is no link included... (so either the )" |
thewilkybarkid commentedDec 12, 2014
@javiereguiluz Fixed now. Got to that point, fixed the code, didn't fix the text. 😃 |
stof commentedDec 12, 2014
👍 |
fabpot commentedDec 12, 2014
Thank you@thewilkybarkid. |
…voke on a controller (thewilkybarkid)This PR was merged into the 2.6 branch.Discussion----------[WebProfilerBundle] Avoid missing method when using __invoke on a controller| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |2.6 added support for using `__invoke` on controllers, but the profiler toolbar still expects a method name, leading to:This PR changes it to only include the method section/double dots if the method name is included (and the `link` is moved to the class name).Commits-------fb87558 Avoid missing method when using __invoke
…ng __invoke on a controller (thewilkybarkid)This PR was merged into the 2.6 branch.Discussion----------[WebProfilerBundle] Avoid missing method when using __invoke on a controller| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |2.6 added support for using `__invoke` on controllers, but the profiler toolbar still expects a method name, leading to:This PR changes it to only include the method section/double dots if the method name is included (and the `link` is moved to the class name).Commits-------fb87558 Avoid missing method when using __invoke
2.6 added support for using
__invokeon controllers, but the profiler toolbar still expects a method name, leading to:This PR changes it to only include the method section/double dots if the method name is included (and the
linkis moved to the class name).