NotificationsYou must be signed in to change notification settings
Fork9.6k
Star30.4k

[Form] [3.0] Remove deprecated OptionsResolverInterface#12909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

michaelperrin wants to merge1 commit intosymfony:masterfrommichaelperrin:remove_deprecated_resolver_interface

Closed

[Form] [3.0] Remove deprecated OptionsResolverInterface#12909

michaelperrin wants to merge1 commit intosymfony:masterfrommichaelperrin:remove_deprecated_resolver_interface

Conversation

Copy link

Contributor

michaelperrin commentedDec 8, 2014

Q	A
Bug fix?	no
New feature?	no
BC breaks?	yes
Deprecations?	no
Tests pass?	no
Fixed tickets	N/A
License	MIT
Doc PR	symfony/symfony-docs#4565

Not sure if is really useful to already open this PR.
I decided to do it after proposing thesymfony/symfony-docs#4565 PR which should
probably be reopened on the master branch of the Symfony docs repository.

Feel free to close the PR if it's not revelant for now!

[Form] Remove deprecated OptionsResolverInterface

5458ddc

Use OptionsResolver instead.

fabpot added the Form label

Dec 18, 2014

stof reviewed

Jan 4, 2015

View reviewed changes

UPGRADE-3.0.md

		Before:

		```php
		protected function configureOptions(OptionsResolverInterface $resolver)

Copy link

Member

stofJan 4, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

the method name is wrong

Copy link

Member

stof commentedJan 4, 2015

I suggest waiting a bit before merging this. Currently, this is the main BC break for the 2.7 to 3.0 upgrade (all other BC breaks are about removing deprecated layers, meaning that 2.7 projects can already avoid them all). It would be good to provide a forward-compatible upgrade path for this change.