Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[2.6] CS Fixes And Removed An Unused Import#12872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This also needs to be applied to the constructor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
That's odd. I'll report this bug to the php-cs-fixer repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Manually fixed this. Thanks for pointing this out@xabbuh.
keradus commentedDec 6, 2014
👍 |
fabpot commentedDec 7, 2014
Thank you@GrahamCampbell. |
…ell)This PR was squashed before being merged into the 2.6 branch (closes#12872).Discussion----------[2.6] CS Fixes And Removed An Unused Import| Q | A| ------------- | ---| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | N/A| License | MIT| Doc PR | N/A##### This pull request fixes some cs issues in symfony 2.6.This is the sequel to#12856.Commits-------2f10a0a [2.6] CS Fixes And Removed An Unused Import
GrahamCampbell commentedDec 7, 2014
@fabpot Is there any chance you could do a 2.6 -> 2.7 merge please? |
fabpot commentedDec 8, 2014
done |
GrahamCampbell commentedDec 8, 2014
Thanks. I probably won't have time to do this now though. Will send a pull to the 2.7 branch on tuesday morning. |
Modify the expected line value which was affected by the move of the`__LINE__` constant insymfony#12872 to make tests pass again.
GrahamCampbell commentedDec 9, 2014
@fabpot There are actually no more cs fixes to be made to 2.7 that weren't already done in 2.6, so there will be no pull from me. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
looks weird?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Well, that's now it's meant to look? Either that, or we shunt it all onto one line?
…(xabbuh)This PR was merged into the 2.6 branch.Discussion----------[HttpKernel] fix DumpDataCollectorTest after CS changes| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |Modify the expected line value which was affected by the move of the`__LINE__` constant in#12872 to make tests pass again.Commits-------1917b70 fix DumpDataCollectorTest after CS changes
This pull request fixes some cs issues in symfony 2.6.
This is the sequel to#12856.