Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[2.5] CS Fixes And Removed Unused Imports#12856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I guess you could move@throws below@return.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
No, the standard seems to be to have param first, then throws, then return.
Symfony itself, is a tad inconsistent with this tbh.
fabpot commentedDec 5, 2014
Thank you@GrahamCampbell. |
This PR was merged into the 2.5 branch.Discussion----------[2.5] CS Fixes And Removed Unused Imports| Q | A| ------------- | ---| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | N/A| License | MIT| Doc PR | N/A##### This pull request fixes some cs issues in symfony 2.5.I've applied the same set of fixes that I did to the 2.3 branch.There are far fewer fixes than there were for 2.3, so I've just done them all at once.Commits-------ed4fb54 CS fixes
…ell)This PR was squashed before being merged into the 2.6 branch (closes#12872).Discussion----------[2.6] CS Fixes And Removed An Unused Import| Q | A| ------------- | ---| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | N/A| License | MIT| Doc PR | N/A##### This pull request fixes some cs issues in symfony 2.6.This is the sequel to#12856.Commits-------2f10a0a [2.6] CS Fixes And Removed An Unused Import
This pull request fixes some cs issues in symfony 2.5.
I've applied the same set of fixes that I did to the 2.3 branch.
There are far fewer fixes than there were for 2.3, so I've just done them all at once.