Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] remove deprecated method 'createEsi'#12663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
FlorianLB commentedNov 29, 2014
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | -- |
| License | MIT |
| Doc PR | -- |
nicolas-grekas commentedNov 29, 2014
Please do not remove method, we first need to merge deprecation notices |
jakzal commentedDec 12, 2014
@FlorianLB are you planning to finish this PR? The method mustn't be removed, but a depreciation error should be triggered instead. Have a look at other PRs of this type and also readJavier's gist, |
FlorianLB commentedDec 12, 2014
No. Depreciation error must be triggered in 2.7 and deprecated method must be removed in 3.0. This PR is about 3.0 not 2.7. I already did it and it has been merged (#12731). |
jakzal commentedDec 12, 2014
Sorry, didn't notice the target branch. We're not removing the methods just yet. |
stof commentedJan 4, 2015
👍 |
fabpot commentedJan 4, 2015
Thank you@FlorianLB. |
… (FlorianLB)This PR was merged into the 3.0-dev branch.Discussion----------[FrameworkBundle] remove deprecated method 'createEsi'| Q | A| ------------- | ---| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | --| License | MIT| Doc PR | --Commits-------5e9aa16 [FrameworkBundle] remove deprecated method 'createEsi'