Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[2.6] Remove possible call_user_func()#12532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
these could both bearray() format callables, this won't work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
no they cannot. See the typehint on setNormalizer, and the detection of lazy options. Both are enforcing the usage of a Closure
stof commentedNov 21, 2014
👍 |
stof commentedNov 21, 2014
btw, similar calls could be removed in 2.3 (the 2.6 branch has moved the logic to a different class in the component, but it is the same) |
fabpot commentedDec 11, 2014
Thank you@nicolas-grekas. |
This PR was merged into the 2.6 branch.Discussion----------[2.6] Remove possible call_user_func()| Q | A| ------------- | ---| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -Remove possible call_user_func() introduced in 2.6Commits-------1de4920 [2.6] Remove possible call_user_func()
Remove possible call_user_func() introduced in 2.6