Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpKernel][2.6] Adding support for invokable controllers in the RequestDataCollector#12443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
jameshalsall wants to merge3 commits intosymfony:masterfromjameshalsall:invokable-controller-request-data-collector
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
fabpot commentedNov 12, 2014
Thank you@jameshalsall. |
fabpot added a commit that referenced this pull requestNov 12, 2014
… in the RequestDataCollector (jameshalsall)This PR was submitted for the master branch but it was merged into the 2.5 branch instead (closes#12443).Discussion----------[HttpKernel][2.6] Adding support for invokable controllers in the RequestDataCollector| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | N/A| License | MIT| Doc PR | N/AAs part of#11193 support for controllers using `__invoke()` was added.The `RequestDataCollector` did not support controllers that were defined in the routing as...```phproute_name: path: /{id} defaults: { _controller: acme_app.page.controller.page } requirements: id: \d+```Where the controller was defined as...```phpclass PageController{ public function __invoke() { // }}```This PR adds that support. Tests have been updated.Commits-------f1d043a [HttpKernel][2.6] Adding support for invokable controllers in the RequestDataCollector
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of#11193 support for controllers using
__invoke()was added.The
RequestDataCollectordid not support controllers that were defined in the routing as...route_name: path: /{id} defaults: { _controller: acme_app.page.controller.page } requirements: id: \d+Where the controller was defined as...
This PR adds that support. Tests have been updated.