Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[DX] [Form] [WebProfiler] Added abbrs with type classes#12268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
kix wants to merge1 commit intosymfony:masterfromkix:profiler_type_abbrs

Conversation

@kix
Copy link
Contributor

@kixkix commentedOct 20, 2014

QA
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketsnone
LicenseMIT
Doc PRnone

This adds an<abbr/> element having a descriptive title that displays the form element's type class name. Everyone wants to know what's the type behind a form child, yes?

Looks like this:
screenshot 2014-10-21 00 22 09

@dunglas
Copy link
Member

Why<abbr>? According tohttps://developer.mozilla.org/en-US/docs/Web/HTML/Element/abbr it should me used for abbreviations and this is not the case here?<div> or<span> instead?

@xabbuh
Copy link
Member

#12267 seems to be a better fix in my opinion.

@kix
Copy link
ContributorAuthor

kix commentedOct 20, 2014

@xabbuh, you've mixed my today's pull requests.#12267 fixes a problem giving a better solution (well, at least IMHO), while this PR adds some verbosity to the component.
@dunglas, I'm using the same pattern as used in the Events profiler tab: listener class names are wrapped with<abbr/>'s there, too.

@stof
Copy link
Member

@kix but in the events panel, this can be considered as an abbreviation, as the display text is the short class name, and the title is the FQCN. Here, you are mixing the name of the field and the class name of the form type being used, which are 2 different things

@stof
Copy link
Member

and giving the name of the form type would be better than its class name IMO anyway

@webmozart
Copy link
Contributor

I'm not sure this is needed. Hovering for 1-2 seconds is much slower than clicking the entry and checking the type on the right, no?

@kix
Copy link
ContributorAuthor

kix commentedOct 23, 2014

Well, technically, it's not clicking, it's the same<abbr/> there, as of Symfony 2.5.5:
screenshot 2014-10-23 11 13 54

@webmozart
Copy link
Contributor

@kix But you can see from your screenshot that the behavior is inconsistent now. Once you hover over thetype name, and then over theform name. Why (from a usability perspective) should hovering over these two different things show the same tooltip?

This adds an <abbr> element having a descriptive title thatdisplays the form element's type class name.
@kix
Copy link
ContributorAuthor

kix commentedOct 27, 2014

A bit more consistent now:
screenshot 2014-10-27 15 39 24
Whendata.type is empty, the tip and the type name are not displayed.

@webmozart
Copy link
Contributor

Better! What does the rest of you think? @symfony/deciders

@fabpot
Copy link
Member

👍

1 similar comment
@stof
Copy link
Member

stof commentedNov 3, 2014

👍

@fabpot
Copy link
Member

Thank you@kix.

fabpot added a commit that referenced this pull requestNov 21, 2014
…(kix)This PR was submitted for the master branch but it was merged into the 2.6 branch instead (closes#12268).Discussion----------[DX] [Form] [WebProfiler] Added abbrs with type classes| Q             | A| ------------- | ---| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | none| License       | MIT| Doc PR        | noneThis adds an `<abbr/>` element having a descriptive title that displays the form element's type class name. Everyone wants to know what's the type behind a form child, yes?Looks like this:![screenshot 2014-10-21 00 22 09](https://cloud.githubusercontent.com/assets/345754/4706604/32cf2d7a-5886-11e4-9fae-b9bff7a419ac.png)Commits-------0d20753 [DX] [Form] [WebProfiler] Added abbrs with type classes
@fabpotfabpot closed thisNov 21, 2014
@kix
Copy link
ContributorAuthor

kix commentedNov 21, 2014

@fabpot 👍! Thanks for merging!

@kixkix deleted the profiler_type_abbrs branchNovember 26, 2014 14:27
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kix@dunglas@xabbuh@stof@webmozart@fabpot

[8]ページ先頭

©2009-2025 Movatter.jp