Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DX] [Form] [WebProfiler] Added abbrs with type classes#12268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
dunglas commentedOct 20, 2014
Why |
xabbuh commentedOct 20, 2014
#12267 seems to be a better fix in my opinion. |
kix commentedOct 20, 2014
@xabbuh, you've mixed my today's pull requests.#12267 fixes a problem giving a better solution (well, at least IMHO), while this PR adds some verbosity to the component. |
stof commentedOct 21, 2014
@kix but in the events panel, this can be considered as an abbreviation, as the display text is the short class name, and the title is the FQCN. Here, you are mixing the name of the field and the class name of the form type being used, which are 2 different things |
stof commentedOct 21, 2014
and giving the name of the form type would be better than its class name IMO anyway |
webmozart commentedOct 22, 2014
I'm not sure this is needed. Hovering for 1-2 seconds is much slower than clicking the entry and checking the type on the right, no? |
kix commentedOct 23, 2014
webmozart commentedOct 23, 2014
@kix But you can see from your screenshot that the behavior is inconsistent now. Once you hover over thetype name, and then over theform name. Why (from a usability perspective) should hovering over these two different things show the same tooltip? |
This adds an <abbr> element having a descriptive title thatdisplays the form element's type class name.
kix commentedOct 27, 2014
webmozart commentedNov 3, 2014
Better! What does the rest of you think? @symfony/deciders |
fabpot commentedNov 3, 2014
👍 |
1 similar comment
stof commentedNov 3, 2014
👍 |
fabpot commentedNov 21, 2014
Thank you@kix. |
…(kix)This PR was submitted for the master branch but it was merged into the 2.6 branch instead (closes#12268).Discussion----------[DX] [Form] [WebProfiler] Added abbrs with type classes| Q | A| ------------- | ---| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | none| License | MIT| Doc PR | noneThis adds an `<abbr/>` element having a descriptive title that displays the form element's type class name. Everyone wants to know what's the type behind a form child, yes?Looks like this:Commits-------0d20753 [DX] [Form] [WebProfiler] Added abbrs with type classes
kix commentedNov 21, 2014
@fabpot 👍! Thanks for merging! |


This adds an
<abbr/>element having a descriptive title that displays the form element's type class name. Everyone wants to know what's the type behind a form child, yes?Looks like this:
