…l, value, index and attribute generation (webmozart)This PR was merged into the 2.7 branch.Discussion----------[Form] Refactored choice lists to support dynamic label, value, index and attribute generationThis is a rebase of#12148 on the 2.7 branch.| Q             | A| ------------- | ---| Bug fix?      | no| New feature?  | yes| BC breaks?    | yes| Deprecations? | yes| Tests pass?   | yes| Fixed tickets |#4067,#5494,#3836,#8658,#12148| License       | MIT| Doc PR        | TODOI implemented the additional options "choice_label", "choice_name", "choice_value", "choice_attr", "group_by" and "choices_as_values" for ChoiceType. Additionally the "preferred_choices" option was updated to accept callables and property paths.The "choices_as_values" option will be removed in Symfony 3.0, where the choices will be passed in the values of the "choices" option by default. The reason for that is that, right now, choices are limited to strings and integers (i.e. valid array keys). When we flip the array, we remove that limitation. Since choice labels are always strings, we can also always use them as array keys:```php// Not possible currently, but possible with "flip_choices"$builder->add('attending', 'choice', array(    'choices' => array(        'Yes' => true,        'No' => false,        'Maybe' => null,    ),    'choices_as_values' => true,));```All the features described here obviously also apply to subtypes of "choice", such as "entity".**choice_label**Returns the label for each choice. Can be a callable (which receives the choice as first and the key of the "choices" array as second argument) or a property path.If `null`, the keys of the "choices" array are used as labels.```php// callable$builder->add('attending', 'choice', array(    'choices' => array(        'yes' => true,        'no' => false,        'maybe' => null,    ),    'choices_as_values' => true,    'choice_label' => function ($choice, $key) {        return 'form.choice.'.$key;    },));// property path$builder->add('attending', 'choice', array(    'choices' => array(        Status::getInstance(Status::YES),        Status::getInstance(Status::NO),        Status::getInstance(Status::MAYBE),    ),    'choices_as_values' => true,    'choice_label' => 'displayName',));```**choice_name**Returns the form name for each choice. That name is used as name of the checkbox/radio form for this choice. It is also used as index of the choice views in the template. Can be a callable (like for "choice_label") or a property path.The generated names must be valid form names, i.e. contain alpha-numeric symbols, underscores, hyphens and colons only. They must start with an alpha-numeric symbol or an underscore.If `null`, an incrementing integer is used as name.```php// callable$builder->add('attending', 'choice', array(    'choices' => array(        'Yes' => true,        'No' => false,        'Maybe' => null,    ),    'choices_as_values' => true,    'choice_name' => function ($choice, $key) {        // use the labels as names        return strtolower($key);    },));// property path$builder->add('attending', 'choice', array(    'choices' => array(        'Yes' => Status::getInstance(Status::YES),        'No' => Status::getInstance(Status::NO),        'Maybe' => Status::getInstance(Status::MAYBE),    ),    'choices_as_values' => true,    'choice_name' => 'value',));```**choice_value**Returns the string value for each choice. This value is displayed in the "value" attributes and submitted in the POST/PUT requests. Can be a callable (like for "choice_label") or a property path.If `null`, an incrementing integer is used as value.```php// callable$builder->add('attending', 'choice', array(    'choices' => array(        'Yes' => true,        'No' => false,        'Maybe' => null,    ),    'choices_as_values' => true,    'choice_value' => function ($choice, $key) {        if (null === $choice) {            return 'null';        }        if (true === $choice) {            return 'true';        }        return 'false';    },));// property path$builder->add('attending', 'choice', array(    'choices' => array(        'Yes' => Status::getInstance(Status::YES),        'No' => Status::getInstance(Status::NO),        'Maybe' => Status::getInstance(Status::MAYBE),    ),    'choices_as_values' => true,    'choice_value' => 'value',));```**choice_attr**Returns the additional HTML attributes for choices. Can be an array, a callable (like for "choice_label") or a property path.If an array, the key of the "choices" array must be used as keys.```php// array$builder->add('attending', 'choice', array(    'choices' => array(        'Yes' => true,        'No' => false,        'Maybe' => null,    ),    'choices_as_values' => true,    'choice_attr' => array(        'Maybe' => array('class' => 'greyed-out'),    ),));// callable$builder->add('attending', 'choice', array(    'choices' => array(        'Yes' => true,        'No' => false,        'Maybe' => null,    ),    'choices_as_values' => true,    'choice_attr' => function ($choice, $key) {        if (null === $choice) {            return array('class' => 'greyed-out');        }    },));// property path$builder->add('attending', 'choice', array(    'choices' => array(        'Yes' => Status::getInstance(Status::YES),        'No' => Status::getInstance(Status::NO),        'Maybe' => Status::getInstance(Status::MAYBE),    ),    'choices_as_values' => true,    'choice_value' => 'htmlAttributes',));```**group_by**Returns the grouping used for the choices. Can be an array/Traversable, a callable (like for "choice_label") or a property path.The return values of the callable/property path are used as group labels. If `null` is returned, a choice is not grouped.If `null`, the structure of the "choices" array is used to construct the groups.```php// default$builder->add('attending', 'choice', array(    'choices' => array(        'Decided' => array(            'Yes' => true,            'No' => false,        ),        'Undecided' => array(            'Maybe' => null,        ),    ),    'choices_as_values' => true,));// callable$builder->add('attending', 'choice', array(    'choices' => array(        'Yes' => true,        'No' => false,        'Maybe' => null,    ),    'choices_as_values' => true,    'group_by' => function ($choice, $key) {        if (null === $choice) {            return 'Undecided';        }        return 'Decided';    },));// property path$builder->add('attending', 'choice', array(    'choices' => array(        'Yes' => Status::getInstance(Status::YES),        'No' => Status::getInstance(Status::NO),        'Maybe' => Status::getInstance(Status::MAYBE),    ),    'choices_as_values' => true,    'group_by' => 'type',));```**preferred_choices**Returns the preferred choices. Can be an array/Traversable, a callable (like for "choice_label") or a property path.```php// array$builder->add('attending', 'choice', array(    'choices' => array(        'Yes' => true,        'No' => false,        'Maybe' => null,    ),    'choices_as_values' => true,    'preferred_choices' => array(true),));// callable$builder->add('attending', 'choice', array(    'choices' => array(        'Yes' => true,        'No' => false,        'Maybe' => null,    ),    'choices_as_values' => true,    'preferred_choices' => function ($choice, $key) {        return true === $choice;    },));// property path$builder->add('attending', 'choice', array(    'choices' => array(        'Yes' => Status::getInstance(Status::YES),        'No' => Status::getInstance(Status::NO),        'Maybe' => Status::getInstance(Status::MAYBE),    ),    'choices_as_values' => true,    'preferred_choices' => 'preferred',));```**Technical Changes**To properly implement all this, the old `ChoiceListInterface` class was deprecated and replaced by a new, slimmer one. The creation of choice views is now separated from choice lists. Hence a lot of logic is not executed anymore when processing (but not displaying) a form.Internally, a `ChoiceListFactoryInterface` implementation is used to construct choice lists and choice views. Two decorators exist for this class:* `CachingFactoryDecorator`: caches choice lists/views so that multiple fields displaying the same choices (e.g. in collection fields) use the same choice list/view* `PropertyAccessDecorator`: adds support for property paths to a factory**BC Breaks**The option "choice_list" of ChoiceType now contains a `Symfony\Component\Form\ChoiceList\ChoiceListInterface` instance, which is a super-type of the deprecated `ChoiceListInterface`.**Todos**- [ ] Adapt CHANGELOGs- [ ] Adapt UPGRADE files- [ ] symfony/symfony-docs issue/PRCommits-------94d18e9 [Form] Fixed CS7e0960d [Form] Fixed failing layout tests1d89922 [Form] Fixed tests using legacy functionalityd6179c8 [Form] Fixed PR comments26eba76 [Form] Fixed regression: Choices are compared by their values if a value callback is givena289deb [Form] Fixed new ArrayChoiceList to compare choices by their values, if enablede6739bf [DoctrineBridge] DoctrineType now respects the "query_builder" option when caching the choice loader3846b37 [DoctrineBridge] Fixed: don't cache choice lists if query builders are constructed dynamically03efce1 [Form] Refactored choice lists to support dynamic label, value, index and attribute generation