Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
minor [Serializer] Fix CS. Uniformize PHPDoc.#12102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
dunglas commentedOct 2, 2014
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| License | MIT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is useless as it does not add any more value than the method signature. Should be removed. Can you do the same where this is the same situation in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Done. Should I remove things like the following?
/** * @var array */protected$normalizers =array();
fabpot commentedOct 3, 2014
Thank you@dunglas. |
This PR was merged into the 2.6-dev branch.Discussion----------minor [Serializer] Fix CS. Uniformize PHPDoc.| Q | A| ------------- | ---| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| License | MITCommits-------5be84c4 [Serializer] Fix CS. Uniformize PHPDoc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this change is actually wrong (PHP-CS-Fixer will revert it the next time we run it though)
This PR was merged into the 2.6-dev branch.Discussion----------[WIP] minor [Serializer] Fix CS| Q | A| ------------- | ---| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| License | MIT* Reverts CS breaks introduced by#12102 found by@stof and@xabbuh.* Fix CS of `PropertyNormalizer` (missed in last commit)Commits-------dffa3e4 [Serializer] Fix CS