Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Form] Added the 'range' FormType#12067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -1105,3 +1105,4 @@ Symfony2 is the result of the work of many people who made the code better | |||
| - Erik Saunier (snickers) | |||
| - Matej Žilák (teo_sk) | |||
| - Vladislav Vlastovskiy (vlastv) | |||
| - Joshua Thijssen (jaytaph) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this is auto-generated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I was not sure. Should I remove the line from the PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
yes
One thing I didn't want to change, is the fact that thevalidatorGuesser guesses "Range" constraints to be a It might make sense to change this into this new |
| @@ -3,9 +3,9 @@ CHANGELOG | |||
| 2.6.0 | |||
| ----- | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this line should not be removed
Please add tests for your new form type. and this will make you notice that you forgot to implement the support of the range type in the PHP form theme |
@stof: ok.. are there currently formtype tests available, as I cannot find them. Maybe i'm looking in the wrong place? |
@jaytaph You can have a look at the tests in |
Any news on this PR? |
Thanks@jaytaph for working on this feature, this is much appreciated. |
This PR was merged into the 2.8 branch.Discussion----------HTML5 range documentationHi,| Q | A| ------------- | ---| Doc fix? | yes| New feature? | yes| BC breaks? | no| Deprecations? | no| Fixed tickets | [#5439]| Code PR | [12607]| License | MITI am trying to contribute to range added for the PRsymfony/symfony#12067 &symfony/symfony#11979 whichfixes#5439 .Need some help on moving for I am really new to the documentation.The current issues I feel is whether we need to add Basic usage or is that only reference ?I had a look athttp://symfony.com/doc/current/reference/forms/types/number.html which would have been similar, but that seems it referencing to choice seems more confusing.I have looked into other types also and almost all are some what similar.Any input is highly appreciated and will work on in the free time. If someone is interested please do take the PR or finish it .Thank you.Commits-------2863079 Fix moving the mapped down as per@xabbuhabf3e8e Fix the rendering issue3c6ff76 Fix issues reported by@snoek09 . Thank you.a2c3f21 Make the necessary changes mentioned by@xabbuh and add example for formd4d1f12 Starting with range documentation
Implemented the "range" FormType.