Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Form] Removed constructor argument from FormTypeHttpFoundationExtension for forward compatibility with 2.5#12033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…ion for forward compatibility with 2.5
c418d9d to6cbc862Comparestof commentedSep 25, 2014
The issue is that this means that using the HttpFoundationExtension will not read headers from HttpFoundation, but from the superglobals (as you have no way to pass a ServerParams instance initialized with the RequestStack). This is very likely to break tests with the WebTestCase, which don't have the superglobals set (as well as code of people running Symfony in a long-running process through a special setup) |
fabpot commentedSep 25, 2014
Thank you@webmozart. |
…ndationExtension for forward compatibility with 2.5 (webmozart)This PR was merged into the 2.3 branch.Discussion----------[Form] Removed constructor argument from FormTypeHttpFoundationExtension for forward compatibility with 2.5| Q | A| ------------- | ---| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -This argument was introduced in#11924. No release was made of the 2.3 branch after merging that PR.Since a different constructor argument (`$requestHandler`) was added to FormTypeHttpFoundationExtension in the 2.5 branch, we cannot merge this forward in a BC fashion. For this reason, I removed the argument again.Commits-------6cbc862 [Form] Removed constructor argument from FormTypeHttpFoundationExtension for forward compatibility with 2.5
webmozart commentedSep 25, 2014
@stof You are right, but that was the same before with FormValidator. We should fix this, but we need to find a proper way to do this. Probably we can only fix this as of 2.5. |
This argument was introduced in#11924. No release was made of the 2.3 branch after merging that PR.
Since a different constructor argument (
$requestHandler) was added to FormTypeHttpFoundationExtension in the 2.5 branch, we cannot merge this forward in a BC fashion. For this reason, I removed the argument again.