Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

#10025 add pipe method to ProcessBuilder#11971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@piotrplenik
Copy link

QA
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#10025
LicenseMIT
Doc PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This should be reverted.

@romainneutron
Copy link
Contributor

See my proposition in#11972

@piotrplenik
Copy link
Author

@jakzal Thanks for comments. All corrected.

@romainneutron
Copy link
Contributor

Hello@jupeter and thanks for your work.
I'm definitely 👎 on this proposition:

  • Piping should not be done atProcess level.Process relies on a command, working directory and is about how to run the command on system. Pipe is a word in the command
  • Piping should not take aProcessBuilder as argument.ProcessBuilder is a factory forProcess. It is semantically wrong.

I do think we should decoupleProcess andCommand� to allow such features.
For this reason, I close this PR in favor of#11972

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@piotrplenik@romainneutron@jakzal@fabpot
[8]ページ先頭
©2009-2025 Movatter.jp