Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DependencyInjection] Added support for closure as a factory method#11968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@unkind
Copy link
Contributor

QA
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
LicenseMIT
Doc PRn/a

I've detached closure's part from#11953. Furthermore, there is no SuperClosure dependency anymore, because I'm not sure if I have to create bridge package by myself.

@unkindunkindforce-pushed thefeature-closure-as-factory-method branch 2 times, most recently from7ff4be2 to958ab11CompareSeptember 20, 2014 13:46
@unkindunkindforce-pushed thefeature-closure-as-factory-method branch from958ab11 to000b348CompareSeptember 20, 2014 22:50
@unkindunkindforce-pushed thefeature-closure-as-factory-method branch from000b348 to75fac20CompareSeptember 21, 2014 11:22
@fabpot
Copy link
Member

2.6 is going to have a new better way to register factories. See#12008

@unkind
Copy link
ContributorAuthor

Yes, that PR looks nice. I'll fix and rebase my PR after merging that one.

@stof
Copy link
Member

I agree this should wait for#12008. Defining a closure in factoryMethod is wrong, as a closure is not a method.

@stof
Copy link
Member

@unkind the PR has been merged

@unkind
Copy link
ContributorAuthor

That's good. I'll make my changes this weekend.

@unkind
Copy link
ContributorAuthor

I wait for#12065.

@unkind
Copy link
ContributorAuthor

I've opened new PR:#12115.

@unkindunkind closed thisOct 3, 2014
@unkindunkind deleted the feature-closure-as-factory-method branchOctober 3, 2014 15:03
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@unkind@fabpot@stof
[8]ページ先頭
©2009-2025 Movatter.jp