Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Form] Add a form error if post_max_size has been reached.#11877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please also add this string in theen translations available in the form component (and for any other language you know of course)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
the form needs to be marked as submitted in this case though, so that the code can know that a submission ended up with errors rather than thinking it is not submitted (and so it is the initial display)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@stof thank for your feedback, i'm agree with you but i don't know how to tackle this : if i simply set $submitted to true the web profiler don't see the form as submitted but if i submit the form, $errors is cleared.
webmozart commentedSep 13, 2014
Why are you duplicating the functionality of FormValidator here? |
stof commentedSep 13, 2014
@webmozart the issue is that the FormValidator does not work well. If the post max size is reached (not the upload max size), |
webmozart commentedSep 15, 2014
…o request handler (rpg600, webmozart)This PR was merged into the 2.3 branch.Discussion----------[Form] Moved POST_MAX_SIZE validation from FormValidator to request handler| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#11729,#11877| License | MIT| Doc PR | -Commits-------759ae1a [Form] Moved POST_MAX_SIZE validation from FormValidator to request handler4780210 [Form] Add a form error if post_max_size has been reached.
This is my new PR following@lyrixx comments.