Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Validator] Added ConstraintViolation::getConstraint()#11657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looking at theBC promise, this can must be documented in theUPGRADE-2.6.md file, mustn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good catch! Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
and also in the Validator changelog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Both updated.
webmozart commentedAug 15, 2014
ping @symfony/deciders |
UPGRADE-2.6.md Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Missing "the" before constraint?
stof commentedAug 18, 2014
👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
cannot be null according to the constructor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Fixed.
romainneutron commentedAug 19, 2014
I'm 👍 on this one, just address@Tobion comment |
Tobion commentedAug 19, 2014
👍 |
… (webmozart)This PR was merged into the 2.6-dev branch.Discussion----------[Validator] Added ConstraintViolation::getConstraint()| Q | A| ------------- | ---| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#5050| License | MIT| Doc PR | -This PR adds a `getConstraint()` method to the `ConstraintViolation` in order to access the constraint causing the violation.Related to#7276,#7273 and#9691.Commits-------ce1d209 [Validator] Added ConstraintViolation::getConstraint()
This PR adds a
getConstraint()method to theConstraintViolationin order to access the constraint causing the violation.Related to#7276,#7273 and#9691.