Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DoctrineBridge] Changed UniqueEntityValidator to use the 2.5 Validation API#11582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
webmozart commentedAug 6, 2014
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #11578 |
| License | MIT |
| Doc PR | - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This won't work, because the valdiator is registered as a service (it has some dependencies)
webmozart commentedAug 6, 2014
@stof That's indeed much better. I'll remove the duplicated legacy classes everywhere. |
webmozart commentedAug 6, 2014
See#11587 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
we generally don't use@author on tests (and@since are not really needed for tests either IMO)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There are quite some tests that have the@author keyword. It's in my file template and I don't think there's any benefit in removing it.
stof commentedAug 6, 2014
👍 |
1 similar comment
Tobion commentedAug 6, 2014
👍 |
…2.5 Validation API (webmozart)This PR was merged into the 2.5 branch.Discussion----------[DoctrineBridge] Changed UniqueEntityValidator to use the 2.5 Validation API| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#11578| License | MIT| Doc PR | -Commits-------f45f1ab [DoctrineBridge] Changed UniqueEntityValidator to use the 2.5 Validation API