Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[MonologBridge] Ignore empty context/extra by default in the ConsoleFormatter#11496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
stof commentedAug 14, 2014
👍 (assuming the Monolog release. Is there an ETA for it ?) |
Contributor
Tobion commentedAug 14, 2014
👍 |
MemberAuthor
Seldaek commentedSep 30, 2014
1.11 is out so I think this is now mergeable? Ping@fabpot |
Member
fabpot commentedSep 30, 2014
Thank you@Seldaek. |
fabpot added a commit that referenced this pull requestSep 30, 2014
…in the ConsoleFormatter (Seldaek)This PR was merged into the 2.6-dev branch.Discussion----------[MonologBridge] Ignore empty context/extra by default in the ConsoleFormatter| Q | A| ------------- | ---| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |This adds support forSeldaek/monolog#388 and turns it on by default since the console output is arguably meant for humans and not for machine readable stuff it makes sense I believe. /cc@Tobion**Note:** This depends on an unreleased version of monolog and should not be merged until 1.11 is out.Commits-------9b69f56 [MonologBridge] Ignore empty context/extra by default in the ConsoleFormatter
Contributor
mpdude commentedSep 14, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This has (unintentionally?) been reverted/disabled in Symfony 3.3 and above by#21705. |
mpdude added a commit to mpdude/symfony that referenced this pull requestSep 14, 2018
This is even enabled by default, which has been the default behaviour sincesymfony#11496.
nicolas-grekas added a commit that referenced this pull requestSep 20, 2018
…xt and extra data (mpdude)This PR was squashed before being merged into the 3.4 branch (closes#28471).Discussion----------[MonologBridge] Re-add option option to ignore empty context and extra data| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |In#11496, an option was added to `ConsoleFormatter` to ignore empty context and extra data. This setting was even turned on by default.The `ConsoleHandler` was then overhauled in#21705. During this change, the option got lost.Commits-------d1e7438 [MonologBridge] Re-add option option to ignore empty context and extra data
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support forSeldaek/monolog#388 and turns it on by default since the console output is arguably meant for humans and not for machine readable stuff it makes sense I believe. /cc@Tobion
Note: This depends on an unreleased version of monolog and should not be merged until 1.11 is out.