Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[WebProfilerBundle][Form] Add information about form synchronization err...#11487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
sstok commentedJul 26, 2014
Epic 👍 sometimes you get a failed transformation because your not using some internal stuff correctly. And its really hard to debug such cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Small detail: we are usingnull !== xxx in Symfony.
fabpot commentedJul 27, 2014
Looks like a great idea.@webmozart Can you check the implementation? |
fabpot commentedJul 27, 2014
To make it even more obvious, what about changing the color to red in the toolbar itself (and probably increment the error count to 1 in this case)? |
psliwa commentedJul 27, 2014
ok, error count in toolbar and in form panel is incremented by 1 for every transformation failure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
TransformationFailedException|null
webmozart commentedSep 26, 2014
psliwa commentedSep 28, 2014
I thought about do that in simillar way as you, but I realized there would be BC-break so I decided to do that in less invasively way. If BC-break is acceptable in that situation, your solution is more elegant and flexible ;) |
When form data transformation fails, the origin error message is lost. This error shouldn't be shown to user, because this is technical error, so maybe a good idea is to show transformation failures in web profiler in
formpanel belowerrorssection?There are no BC-breaks in this PR, I have added public internal method to
Symfony\Component\Form\Formclass, that returnsTransformationFailedException, it is used byFormDataExtractor.Symfony\Component\Form\FormInterfacehas not been touched by me, because that would be a BC-break.