Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Validator] Fixed object initializers in 2.5 version of the Validator#11410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
webmozart merged 1 commit intosymfony:2.5fromwebmozart:issue11159
Jul 21, 2014

Conversation

@webmozart
Copy link
Contributor

QA
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#11159
LicenseMIT
Doc PR-

Object initializers were forgot in the 2.5 Validator API. This PR implements them.

A bug was fixed also in the old version which resulted in the initializers being called multiple times if an object was validated in multiple groups within the same validation run. This fix will be backported separately to older versions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

you already added a use statement for this

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Removed the use statement.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We are doing the opposite in Symfony. Use the class name in phpdocs and add a use statement.

@kbond
Copy link
Member

fixes the problem for me!

@fabpot
Copy link
Member

👍

1 similar comment
@stof
Copy link
Member

👍

webmozart added a commit to webmozart/symfony that referenced this pull requestJul 18, 2014
fabpot added a commit that referenced this pull requestJul 18, 2014
…are called only once per object (webmozart)This PR was merged into the 2.3 branch.Discussion----------[Validator] Backported#11410 to 2.3: Object initializers are called only once per object| Q             | A| ------------- | ---| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -Before, object initializers were called multiple times if an object was validated in different groups in the same validation run. The initializers, however, are not aware of the current validation group, so calling them more than once does not make sense.Now, object initializers are called exactly once per validated object.See#11410Commits-------291cbf9 [Validator] Backported#11410 to 2.3: Object initializers are called only once per object
webmozart added a commit to webmozart/symfony that referenced this pull requestJul 21, 2014
…n of the Validator (webmozart)This PR was merged into the 2.5 branch.Discussion----------[Validator] Fixed object initializers in 2.5 version of the Validator| Q             | A| ------------- | ---| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |symfony#11159| License       | MIT| Doc PR        | -Object initializers were forgot in the 2.5 Validator API. This PR implements them.A bug was fixed also in the old version which resulted in the initializers being called multiple times if an object was validated in multiple groups within the same validation run. This fix will be backported separately to older versions.Commits-------ce04073 [Validator] Fixed object initializers in 2.5 version of the Validator
@webmozartwebmozart merged commitce04073 intosymfony:2.5Jul 21, 2014
webmozart added a commit that referenced this pull requestJul 21, 2014
…e Validator (webmozart)This PR was merged into the 2.5 branch.Discussion----------[Validator] Fixed object initializers in 2.5 version of the Validator| Q             | A| ------------- | ---| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#11159| License       | MIT| Doc PR        | -Object initializers were forgot in the 2.5 Validator API. This PR implements them.A bug was fixed also in the old version which resulted in the initializers being called multiple times if an object was validated in multiple groups within the same validation run. This fix will be backported separately to older versions.Commits-------ce04073 [Validator] Fixed object initializers in 2.5 version of the Validator
fabpot added a commit that referenced this pull requestJul 24, 2014
* 2.3:  [Translator] Use quote to surround invalid locale  Optimize assertLocale regexp  [Validator] Backported#11410 to 2.3: Object initializers are called only once per object  [Translator][FrameworkBundle] Added @ to the list of allowed chars in Translator  [Process] Reduce I/O load on Windows platform  [Form] Check if IntlDateFormatter constructor returned a valid object before using it
fabpot added a commit that referenced this pull requestJul 24, 2014
* 2.4:  [Translator] Use quote to surround invalid locale  Optimize assertLocale regexp  [ExpressionLanguage] Fixed an issue with # characters in double quoted string literals  Add some tweaks to the pt_BR translations  [Validator] Backported#11410 to 2.3: Object initializers are called only once per object  [Translator][FrameworkBundle] Added @ to the list of allowed chars in Translator  [Process] Reduce I/O load on Windows platform  [Form] Check if IntlDateFormatter constructor returned a valid object before using itConflicts:src/Symfony/Component/Validator/Tests/ValidationVisitorTest.php
fabpot added a commit that referenced this pull requestJul 24, 2014
* 2.5:  [Translator] Use quote to surround invalid locale  [Validator] Fixed memory leak in ValidatorBuilder  [FrameworkBundle] changed KernelTestCase::getKernelClass() to check $_SERVER['KERNEL_DIR'] before invoking getPhpUnitXmlDir()  Optimize assertLocale regexp  [ExpressionLanguage] Fixed an issue with # characters in double quoted string literals  [Validator] Fixed object initializers in 2.5 version of the Validator  Add some tweaks to the pt_BR translations  [Validator] Backported#11410 to 2.3: Object initializers are called only once per object  [Translator][FrameworkBundle] Added @ to the list of allowed chars in Translator  [Process] Reduce I/O load on Windows platform  [Form] Check if IntlDateFormatter constructor returned a valid object before using itConflicts:src/Symfony/Component/Process/ProcessPipes.php
romainneutron added a commit that referenced this pull requestJul 25, 2014
…romainneutron)This PR was merged into the 2.3 branch.Discussion----------fix signal handling in wait() on calls to stop()| Q             | A| ------------- | ---| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#11286| License       | MIT| Doc PR        |``wait()`` throws an exception when the process was terminated by a signal. This should not happen when the termination was requested by calling the ``stop()`` method (for example, inside a callback which is passed to ``wait()``).Commits-------5939d34 [Process] Fix unit tests in sigchild environmenteb68662 [Process] fix signal handling in wait()94ffc4f bug#11469  [BrowserKit] Fixed server HTTP_HOST port uri conversion (bcremer, fabpot)103fd88 [BrowserKit] refactor code and fix unquoted regexf401ab9 Fixed server HTTP_HOST port uri conversion045cbc5 bug#11425 Fix issue described in#11421 (Ben, ben-rosio)f5bfa9b bug#11423 Pass a Scope instance instead of a scope name when cloning a container in the GrahpvizDumper (jakzal)3177be5 minor#11464 [Translator] Use quote to surround invalid locale (lyrixx)c9742ef [Translator] Use quote to surround invalid locale4dbe0e1 bug#11120 [2.3][Process] Reduce I/O load on Windows platform (romainneutron)797d814 bug#11342 [2.3][Form] Check if IntlDateFormatter constructor returned a valid object before using it (romainneutron)0b5348e minor#11441 [Translator] Optimize assertLocale regexp (Jérémy Derussé)537c39b Optimize assertLocale regexp4cf50e8 Bring code into standard9f4313c [Process] Add test to verify fix for issue#1142102eb765 [Process] Fixes issue#114216787669 [DependencyInjection] Pass a Scope instance instead of a scope name.9572918 bug#11411 [Validator] Backported#11410 to 2.3: Object initializers are called only once per object (webmozart)291cbf9 [Validator] Backported#11410 to 2.3: Object initializers are called only once per objectefab884 bug#11403 [Translator][FrameworkBundle] Added @ to the list of allowed chars in Translator (takeit)3176f8b [Translator][FrameworkBundle] Added @ to the list of allowed chars in Translator91e32f8 bug#11381 [2.3] [Process] Use correct test for empty string in UnixPipes (whs, romainneutron)45df2f3 minor#11397 [2.3][Process] Fix unit tests on Windows platform (romainneutron)cec0a45 [Process] Adjust PR#11264, make it Windows compatible and fix CSd418935 [Process] Fix unit tests on Windows platformff0bb01 [Process] Reduce I/O load on Windows platformace5a29 bumped Symfony version to 2.3.1975e07e6 updated VERSION for 2.3.184a12f4d update CONTRIBUTORS for 2.3.1898b891d updated CHANGELOG for 2.3.1806a80fb Validate locales sets intos translator06fc97e feature#11367 [HttpFoundation] Fix to prevent magic bytes injection in JSONP responses... (CVE-2014-4671) (Andrew Moore)3c54659 minor#11387 [2.3] [Validator] Fix UserPassword validator translation (redstar504)73d50ed Fix UserPassword validator translation93a970c bug#11386 Remove Spaceless Blocks from Twig Form Templates (chrisguitarguy)8f9ed3e Remove Spaceless Blocks from Twig Form Templates9e1ea4a [Process] Use correct test for empty string in UnixPipes6af3d05 [HttpFoundation] Fix to prevent magic bytes injection in JSONP responses (PreventsCVE-2014-4671)ebf967d [Form] Check if IntlDateFormatter constructor returned a valid object before using it
oleg-andreyev pushed a commit to oleg-andreyev/symfony that referenced this pull requestJul 25, 2014
* upstream/master: (1619 commits)  fixed CS  [Translator] Use quote to surround invalid locale  Allow exception bubbling in RememberMeListener  [FrameworkBundle] improved controller name parse error message  [DomCrawler] Added node name getter  [Validator] Fixed memory leak in ValidatorBuilder  [FrameworkBundle] changed KernelTestCase::getKernelClass() to check $_SERVER['KERNEL_DIR'] before invoking getPhpUnitXmlDir()  [Validator] Improve UserPassword message  Optimize assertLocale regexp  [ExpressionLanguage] Fixed an issue with # characters in double quoted string literals  [Validator] Fixed object initializers in 2.5 version of the Validator  [Console] Fix test on windows  Add some tweaks to the pt_BR translations  [Validator] Backportedsymfony#11410 to 2.3: Object initializers are called only once per object  Rename Specificity->compare() to compareTo()  [Translator][FrameworkBundle] Added @ to the list of allowed chars in Translator  fixed CS  Add compare method to Specificity  [Process] Adjust PRsymfony#11264, make it Windows compatible and fix CS  [Process] Fix unit tests on Windows platform  ...
@webmozartwebmozart deleted the issue11159 branchAugust 4, 2014 14:41
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@webmozart@kbond@fabpot@stof@Tobion@romainneutron

[8]ページ先頭

©2009-2025 Movatter.jp