NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

Added support for encoding and decoding namespaced xml (xmlns)#11375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:masterfromClementGautier:moved_serializer_5

Jul 25, 2014

Merged

Added support for encoding and decoding namespaced xml (xmlns)#11375

fabpot merged 1 commit intosymfony:masterfromClementGautier:moved_serializer_5

Jul 25, 2014

Conversation

Copy link

Contributor

ClementGautier commentedJul 11, 2014

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#10625
License	MIT

Complete this PR :#9156

Copy link

ContributorAuthor

ClementGautier commentedJul 11, 2014

@mattvick I've rewritten your commit to use the new implementation, I hope its ok for you.

Copy link

Contributor

mattvick commentedJul 11, 2014

@ClementGautier sure thanks

Copy link

Member

fabpot commentedJul 11, 2014

👍

jakzal reviewed

Jul 11, 2014

View reviewed changes

src/Symfony/Component/Serializer/Encoder/XmlEncoder.php Outdated

Copy link

Contributor

jakzalJul 11, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

should beforeach ($xpath->query('namespace::*', $dom->documentElement) as $nsNode) {

Copy link

ContributorAuthor

ClementGautierJul 12, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@jakzal thanks

Added support for encoding and decoding namespaced xml (xmlns)

9d6b20c

Copy link

Contributor

jakzal commentedJul 12, 2014

👍

romainneutron added the Serializer label

Jul 12, 2014

staabm reviewed

Jul 12, 2014

View reviewed changes

src/Symfony/Component/Serializer/Encoder/XmlEncoder.php

Copy link

Contributor

staabmJul 12, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

isset is unnecessary...unset will work without warning if the key is defined or not

Copy link

Member

fabpotJul 25, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I've fixed this in21e7ad7

Copy link

Member

fabpot commentedJul 25, 2014

Thank you@ClementGautier.

fabpot merged commit9d6b20c intosymfony:master

Jul 25, 2014

fabpot added a commit that referenced this pull request

Jul 25, 2014

feature#11375Added support for encoding and decoding namespaced xml…

c0e4dc6

… (xmlns) (mattvick)This PR was merged into the 2.6-dev branch.Discussion----------Added support for encoding and decoding namespaced xml (xmlns)Q | A------------ | -------------Bug fix? | noNew feature? | yesBC breaks? | noDeprecations? | noTests pass? | yesFixed tickets |#10625License | MITComplete this PR :#9156Commits-------9d6b20c Added support for encoding and decoding namespaced xml (xmlns)