Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

remove the scope from the output of the container:debug command#11317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromxabbuh:issue-11302
Jul 23, 2014

Conversation

@xabbuh
Copy link
Member

QA
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#11302
LicenseMIT
Doc PR

@javiereguiluz
Copy link
Member

I've checked the Symfony documentation and there are no listings for the output of thecontainer:debug command, so it's not necessary a doc PR to complement this PR.

@xabbuh
Copy link
MemberAuthor

@javiereguiluz Thanks for checking the docs.

@stof
Copy link
Member

stof commentedJul 8, 2014

👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I would not removed the scope from non-text formats (YAML, XML, ...) as they mostly consumed by tools that might need this information.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Fair point.

What do you think about the output of a single service? Would you like to keep the scope there too as@stof suggested?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think that makes sense.

@xabbuh
Copy link
MemberAuthor

I updated the pull request to remove the scope information only in the list of services when the text format is used.

@fabpot
Copy link
Member

👍

@fabpot
Copy link
Member

Thank you@xabbuh.

@fabpotfabpot merged commitf56b731 intosymfony:masterJul 23, 2014
fabpot added a commit that referenced this pull requestJul 23, 2014
…g command (xabbuh)This PR was merged into the 2.6-dev branch.Discussion----------remove the scope from the output of the container:debug command| Q             | A| ------------- | ---| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#11302| License       | MIT| Doc PR        |Commits-------f56b731 remove the scope from the output of the container:debug command
@xabbuhxabbuh deleted the issue-11302 branchJuly 24, 2014 19:11
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@xabbuh@javiereguiluz@stof@fabpot@romainneutron

[8]ページ先頭

©2009-2025 Movatter.jp