Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DX] Added line feed to container alias description (text descriptor)#11305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Wouldn't it be better to use the system independentPHP_EOL constant instead of\n?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The whole file is using\n, see lines 60, 94, 110, 128...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There's only one use ofPHP_EOL that's not testing related in the whole symfony/symfony repo. I don't remember why but I think that was a choice made by the the core at some point.
zefrog commentedJul 5, 2014
I think Travis failure is not related to my PR... Tests are passing :) |
fabpot commentedJul 25, 2014
Thank you@zefrog. |
…t descriptor) (Maxime Douailin)This PR was merged into the 2.6-dev branch.Discussion----------[DX] Added line feed to container alias description (text descriptor)| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | N/AThis PR just adds a line feed at the end of the alias service description delivered by the ContainerDebugCommand. Tests are passing because expected outputs are trimmed before comparison (which IMO is not a really good thing, but hey...)Commits-------13c011c Added line feed to container alias description (text descriptor)
This PR just adds a line feed at the end of the alias service description delivered by the ContainerDebugCommand. Tests are passing because expected outputs are trimmed before comparison (which IMO is not a really good thing, but hey...)