Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Security] Add missing dot at the end of an exception message#11215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromrybakit:patch-1
Jul 25, 2014
Merged

[Security] Add missing dot at the end of an exception message#11215

fabpot merged 1 commit intosymfony:masterfromrybakit:patch-1
Jul 25, 2014

Conversation

@rybakit
Copy link
Contributor

QA
Fixed tickets-
LicenseMIT

@stof
Copy link
Member

I'm not sure about it. the message is not a sentence anyway.

@rybakit
Copy link
ContributorAuthor

What about this message (

) then? And would it make sense to maybe replace "Bad credentials" with "Invalid credentials."?

@fabpot
Copy link
Member

We do have dots on all error messages, so I think it makes sense. 👍

@fabpot
Copy link
Member

Thank you@rybakit.

@fabpotfabpot merged commit8e1f978 intosymfony:masterJul 25, 2014
fabpot added a commit that referenced this pull requestJul 25, 2014
…ssage (rybakit)This PR was merged into the 2.6-dev branch.Discussion----------[Security] Add missing dot at the end of an exception message| Q             | A| ------------- | ---| Fixed tickets | -| License       | MITCommits-------8e1f978 Add missing dot at the end of an exception message
@phansys
Copy link
Contributor

IMHO, the dots at exceptions could be omitted to allow imbricated handling of exceptions. For example, when rendering a message from a catchable exception.

phansys added a commit to phansys/FOSUserBundle that referenced this pull requestAug 4, 2014
phansys added a commit to phansys/FOSUserBundle that referenced this pull requestAug 4, 2014
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rybakit@stof@fabpot@phansys@raziel057
[8]ページ先頭
©2009-2025 Movatter.jp