Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Routing] Optional placeholders anywhere in the pattern#112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
If we allow this, the router results are not predictable anymore. I don't why you think that having more routes looks ugly but this is definitely the way to go. |
SofHad pushed a commit to SofHad/symfony that referenced this pull requestOct 12, 2015
This PR was merged into the master branch.Discussion----------Updated to Symfony 2.7.2Commits-------c255f06 Updated to Symfony 2.7.2
derrabus added a commit to derrabus/symfony that referenced this pull requestJul 25, 2023
This PR was merged into the 2.2-dev branch.Discussion----------Bump psr/http-message versionClosessymfony#112Commits-------ec83c1c Bump psr/http-message version
This pull request wasclosed.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I encountered a limitation with optional placeholders.
Currently they are available only in the end of the pattern, e.g.:
/static/optional1/optional2/optional3/ or /optional1/optional2/
However this limits the usage of optional placeholders and is solvable only with multiple patterns which looks ugly if you have many of them.
One of the use cases:
/products/{optional_culture}/{optional_category1}/{optional_category2}/{optional_category3}/{product_id}
This pull requests adds support for having as many optional placeholders in any order it is needed.
If you want to create an optional placeholder, it is needed to specify default value for it as it was before. However in these use cases you might want to have empty default value, so support for an empty default string value was added. Before it was not possible to assign empty string as a default placeholder value.
I don't know if this is a thing that has to be in the core, it could be separated as a custom route compiler, however I would like to get your comments on this one.