Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpFoundation] smaller fixes for PdoSessionHandler#11009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…s, fix merge for sqlsrv and oracle
ContributorAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
TODO: Needs holdlock...http://weblogs.sqlteam.com/dang/archive/2009/01/31/UPSERT-Race-Condition-With-MERGE.aspx
ContributorAuthor
Tobion commentedJun 4, 2014
@fabpot ready |
Member
fabpot commentedJun 4, 2014
Thank you@Tobion. |
fabpot added a commit that referenced this pull requestJun 4, 2014
This PR was merged into the 2.3 branch.Discussion----------[HttpFoundation] smaller fixes for PdoSessionHandler| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#10652| License | MITFor both the PdoSessionHandler and DbalSessionHandler-#10652 (comment): Transactional DELETE + INSERT does not work as expected-#10652 (comment): sqlsrv 2005 does not support the MERGE SQL, and if used it requires an HOLDLOCK- missing time update for sqlsrv and oracleCommits-------a0e1d4d [Doctrine Bridge] fix DBAL session handler according to PdoSessionHandler00d707f [HttpFoundation] use different approach for duplicate keys in postgres, fix merge for sqlsrv and oracle
fabpot added a commit that referenced this pull requestJun 6, 2014
This PR was merged into the 2.3 branch.Discussion----------[HttpFoundation] fix switch statement| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#11009| License | MITCommits-------da24bc9 [HttpFoundation] fix switch statement
Member
fabpot commentedJun 6, 2014
@Tobion Can you help me merge this one on master? |
ContributorAuthor
Tobion commentedJun 6, 2014
Yes I'll make a PR. |
Tobion added a commit to Tobion/symfony that referenced this pull requestJun 6, 2014
ContributorAuthor
Tobion commentedJun 6, 2014
fabpot added a commit that referenced this pull requestJun 7, 2014
This PR was merged into the 2.3-dev branch.Discussion----------[HttpFoundation]#11009 for master| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MITCommits-------8d375ca [HttpFoundation] merge#11009 into master
symfony-splitter pushed a commit to symfony/doctrine-bridge that referenced this pull requestJun 7, 2014
symfony-splitter pushed a commit to symfony/http-foundation that referenced this pull requestSep 22, 2014
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For both the PdoSessionHandler and DbalSessionHandler