NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Security] Role class magic method to make comparisons easier#10970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

darektw wants to merge3 commits intosymfony:masterfromdarektw:patch-1

Closed

[Security] Role class magic method to make comparisons easier#10970

darektw wants to merge3 commits intosymfony:masterfromdarektw:patch-1

Conversation

Copy link

darektw commentedMay 22, 2014

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets
License	MIT
Doc PR

Now

in_array('ROLE_ADMIN', $user->getRoles())

will work.

I know this can be done with $user->hasRole() method, but consider following:

!!array_intersect(array('ROLE_1', 'ROLE_2'), $user->getRoles())

to check if user has at least one of roles.

[Component][Security][Role] added magic method to make comparisons ea…

7ceb144

…sier.Now ```in_array('ROLE_ADMIN', $user->getRoles())``` will work.I know this can be done with $user->hasRole() method, but consider following:```!!array_intersect(array('ROLE_1', 'ROLE_2'), $user->getRoles())```to check if user has at least one of roles.

darektw changed the title~~[Component][Security][Role] magic method to make comparisons easier~~[Security] Role class magic method to make comparisons easier

May 22, 2014

Update Role.php

23fa5d8

Copy link

Author

darektw commentedMay 22, 2014

Travis failure is not my fault...

Failed asserting that exception message 'Symfony\Component\Process\Process::setInput only accepts strings.' contains 'Symfony\Component\Process\Process::setStdin only accepts strings.'.

Update Role.php

26c5fb4

Copy link

Member

checking if a user has some roles should be done using the security voters, not usinghasRole directly (which is meant to be used by the voter layer).
If you call the check on the user directly, the role hierarchy will not be taken into account