Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Debug] cleanup interfaces before 2.5-final#10941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedMay 20, 2014
Call for review: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
why duplicating all this logic here, while it is already done by the parent class ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Right, I'll add an argument to the constructor instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
is there a difference in the logic in both cases ? I haven't checked the code locally to be able to compare both files easily
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
OK, saw it. It is the usage of params in the trace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Fixed
nicolas-grekas commentedMay 21, 2014
Any comment here? Otherwise@fabpot this is 👍 for merge in 2.5 on my side |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
missing documentation for@return
fabpot commentedMay 21, 2014
Thank you@nicolas-grekas. |
…rekas)This PR was merged into the 2.4-dev branch.Discussion----------[Debug] cleanup interfaces before 2.5-final| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | none| License | MIT| Doc PR | noneThis PR is targeted at cleaning up interfaces before 2.5 final:- ExceptionHandlerInterface has never been released in a stable Symfony, lets drop it, not deprecate it,- generalize a little bit how fatal errors are handled and make them take the same path as uncaught exceptions,- enhance handling of out of memory situations.Commits-------e3255bf [Debug] better ouf of memory error handlingdfa8ff8 [Debug] cleanup interfaces before 2.5-final
This PR is targeted at cleaning up interfaces before 2.5 final: