Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpKernel] Fix "absolute path" when we look to the cache directory#10937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
BenoitLeveque wants to merge1 commit intosymfony:masterfromBenoitLeveque:fix-relative-cache-path-with-var-directory
Closed
[HttpKernel] Fix "absolute path" when we look to the cache directory#10937
BenoitLeveque wants to merge1 commit intosymfony:masterfromBenoitLeveque:fix-relative-cache-path-with-var-directory
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
We should get __DIR__ instead of __DIR__ . '/.'
Member
fabpot commentedMay 18, 2014
Good catch, thanks@BenoitLeveque. |
fabpot added a commit that referenced this pull requestMay 18, 2014
… directory (BenoitLeveque)This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#10937).Discussion----------[HttpKernel] Fix "absolute path" when we look to the cache directory| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |We should get ``__DIR__`` instead of ``__DIR__ . '/.'``I've seen this issue when trying to play with the symfony standard new directory structureCommits-------4735e56 Fix "absolute path" when we look to the cache directory
fabpot added a commit that referenced this pull requestMay 26, 2014
* 2.3: Revert "bug#10894 [HttpKernel] removed absolute paths from the generated container (fabpot)" Revert "bug#10937 [HttpKernel] Fix "absolute path" when we look to the cache directory (BenoitLeveque)" Revert "fixed CS" Revert "bug#10979 Make rootPath part of regex greedy (artursvonda)" Revert "[HttpKernel] simplified some tests" [HttpKernel] simplified some tests Make rootPath part of regex greedyConflicts:src/Symfony/Component/HttpKernel/Tests/KernelTest.php
fabpot added a commit that referenced this pull requestMay 26, 2014
* 2.4: Revert "bug#10894 [HttpKernel] removed absolute paths from the generated container (fabpot)" Revert "bug#10937 [HttpKernel] Fix "absolute path" when we look to the cache directory (BenoitLeveque)" Revert "fixed CS" Revert "bug#10979 Make rootPath part of regex greedy (artursvonda)" Revert "[HttpKernel] simplified some tests" [HttpKernel] simplified some tests Make rootPath part of regex greedy
fabpot added a commit that referenced this pull requestMay 26, 2014
* 2.5: Revert "bug#10894 [HttpKernel] removed absolute paths from the generated container (fabpot)" Revert "bug#10937 [HttpKernel] Fix "absolute path" when we look to the cache directory (BenoitLeveque)" Revert "fixed CS" Revert "bug#10979 Make rootPath part of regex greedy (artursvonda)" Revert "[HttpKernel] simplified some tests" [HttpKernel] simplified some tests Make rootPath part of regex greedy
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should get
__DIR__instead of__DIR__ . '/.'I've seen this issue when trying to play with the symfony standard new directory structure