Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Process] Deprecate Process::setStdin in favor of Process::setInput#10932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Typo: getInput
romainneutron commentedMay 18, 2014
PR updated, typo fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It does not always write to stdin anymore, does it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
If an input is passed, yes it's written to the underlying process's stdin.
romainneutron commentedMay 19, 2014
PR Updated, comments addressed |
UPGRADE-3.0.md Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The method names should end with()
romainneutron commentedMay 22, 2014
@fabpot updated, changed target to 2.5 instead of 2.6 |
fabpot commentedMay 22, 2014
Thanks@romainneutron. |
…ess::setInput (romainneutron)This PR was merged into the 2.3-dev branch.Discussion----------[Process] Deprecate Process::setStdin in favor of Process::setInput| Q | A| ------------- | ---| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | yes| Tests pass? | yes| Fixed tickets | n/a| License | MITFrom the `Process` point of view, what we pass is an *input*, as well as we retrieve *output* and *error output*.As we use `getOutput` and `getErrorOutput` we should use `setInput` and let the underlying `ProcessPipes` deal with the actual `STDIN`.By the way, `ProcessBuilder` already has `setInput` method and no `setStdin` methodCommits-------53b9d73 [Process] Deprecate Process::setStdin in favor of Process::setInput
darektw commentedMay 22, 2014
it does not pass tests... please change tested exception messages! |
romainneutron commentedMay 22, 2014
Thanks for the report @MarcomTeam. The issue has been introduced while merging 2.3 in master. A PR has been submitted, it should be fixed soon. |
…recation (romainneutron)This PR was merged into the 2.3-dev branch.Discussion----------[Process] Fix conflicts between latest 2.3 fix and 2.5 deprecation| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | n/a| License | MITAs reported in#10932 (comment), it's been introduced when merging 2.3 in masterCommits-------3454d60 [Process] Fix conflicts between latest 2.3 fix and 2.5 deprecation
From the
Processpoint of view, what we pass is aninput, as well as we retrieveoutput anderror output.As we use
getOutputandgetErrorOutputwe should usesetInputand let the underlyingProcessPipesdeal with the actualSTDIN.By the way,
ProcessBuilderalready hassetInputmethod and nosetStdinmethod