Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Process] Deprecate using values that are not string for Process::setStdin and ProcessBuilder::setInput#10930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
stream resources are not accepted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
and I would not forbid passing another scalar but just cast it when setting it. PHP does not have strict types for scalars
romainneutron commentedMay 22, 2014
PR rebased and updated, comments addressed. |
UPGRADE-3.0.md Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
missing() at the end of the method name (same below).
romainneutron commentedMay 22, 2014
PR Updated, comments addressed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
we don't trigger deprecation errors for stuff working until 3.0. We will only do it the last minor release before 3.0
…Stdin and ProcessBuilder::setInput
romainneutron commentedMay 23, 2014
PR updated,@stof comments addressed |
…or Process::setStdin and ProcessBuilder::setInput (romainneutron)This PR was merged into the 2.4-dev branch.Discussion----------[Process] Deprecate using values that are not string for Process::setStdin and ProcessBuilder::setInput| Q | A| ------------- | ---| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | yes| Tests pass? | yes| Fixed tickets | n/a| License | MITThis deprecates passing a `Process` input any value that is not a strict string. This needs#10929 to be merged.I don't know if the use of `trigger_error` is correct or should be removed.Commits-------9887b83 [Process] Deprecate using values that are not string for Process::setStdin and ProcessBuilder::setInput
This deprecates passing a
Processinput any value that is not a strict string. This needs#10929 to be merged.I don't know if the use of
trigger_erroris correct or should be removed.