Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[2.3] Fix phpunit test suite on travis #2#10826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 2 commits intosymfony:2.3fromromainneutron:phpunit-travis-2
Apr 30, 2014

Conversation

romainneutron
Copy link
Contributor

QA
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#10821
LicenseMIT

This is a second approach to solve#10821.
Something is weird:Symfony\Component\Form\Tests\Extension\Core\EventListener\TrimListenerTest passes when using PHPUnit as phar and fails when using a composer global install

@romainneutronromainneutron changed the title[2.3] Fix phpunit test suite on travis[2.3] Fix phpunit test suite on travis #2Apr 30, 2014
@romainneutron
Copy link
ContributorAuthor

Forget what I said,Symfony\Component\Form\Tests\Extension\Core\EventListener\TrimListenerTest is still failing

This implementation does not seem to work, anyway

@stof
Copy link
Member

Reopening as waiting for the PHPUnit release was necessary forphpunit --self-update to give us a fixed version

@stof
Copy link
Member

arf, PHP 5.3.3 does not have openssl on Travis 😞

@stof
Copy link
Member

@romainneutron an alternative could be to downloadhttps://phar.phpunit.de/phpunit.phar with wget and replacing the existing phar with it, instead of asking PHPUnit to perform the download. This would fix the openssl issue on 5.3.3

@romainneutron
Copy link
ContributorAuthor

yep that's the only solution, I'm gonna give a try to this proposition

@fabpotfabpot merged commit32e5f67 intosymfony:2.3Apr 30, 2014
fabpot added a commit that referenced this pull requestApr 30, 2014
This PR was merged into the 2.3 branch.Discussion----------[2.3] Fix phpunit test suite on travis#2| Q             | A| ------------- | ---| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#10821| License       | MITThis is a second approach to solve#10821.Something is weird: `Symfony\Component\Form\Tests\Extension\Core\EventListener\TrimListenerTest` passes when using PHPUnit as phar and fails when using a composer global installCommits-------32e5f67 [DependencyInjection] Fix travis unit testsc7befd5 Update PHPUnit before run
@stof
Copy link
Member

stof commentedMay 1, 2014

@romainneutron this is actually not needed anymore (for the Travis update part), as Travis updated PHPUnit to 4.0.19

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@romainneutron@stof@fabpot

[8]ページ先頭

©2009-2025 Movatter.jp