Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Config] fix docblock#10750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
pyrech wants to merge1 commit intosymfony:masterfrompyrech-forks:master
Closed

Conversation

@pyrech
Copy link
Contributor

QA
Fixed ticketsnone
LicenseMIT

Some phpdoc are wrong in the Config component after the PR#10701 was merged.
eg:
IntegerNode was changed to intNode
BooleanNodeDefinition was changed to boolNodeDefinition

@pyrechpyrech changed the title[Config] fix docblock broken in #10701[Config] fix docblockApr 20, 2014
@pyrech
Copy link
ContributorAuthor

It seems that the fabbot need to be fixed too...

@wouterj
Copy link
Member

👍

@romainneutron
Copy link
Contributor

👍 but this should be merged in 2.3

@pyrech
Copy link
ContributorAuthor

Should I reopen a PR against 2.3? And what about fixing fabbot?

@wouterj
Copy link
Member

@pyrech fabbot is a private tool currently, so only some people can fix that (but I'm sure they will). You don't have to open this for 2.3,@fabpot has a tool which can patch this perfectly in there.

@pyrech
Copy link
ContributorAuthor

Ok, thanks for explanations :)

@fabpot
Copy link
Member

Thank you@pyrech.

fabpot added a commit that referenced this pull requestApr 22, 2014
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#10750).Discussion----------[Config] fix docblock| Q             | A| ------------- | ---| Fixed tickets | none| License       | MITSome phpdoc are wrong in the Config component after the PR#10701 was merged.eg:    IntegerNode was changed to intNode    BooleanNodeDefinition was changed to boolNodeDefinitionCommits-------68debfb fix docblock
@fabpotfabpot closed thisApr 22, 2014
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pyrech@wouterj@romainneutron@fabpot
[8]ページ先頭
©2009-2025 Movatter.jp