Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Made types used by Symfony compatible with the ones of Hack#10701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
extra spaces should be removed
stof commentedApr 13, 2014
except for the phpdoc issues (there is a few more than the 2 I commented on), this is a 👍 |
wouterj commentedApr 13, 2014
oh yeah, this finally makes an end to the Boolean/boolean/bool fight :)#4183 |
pborreli commentedApr 13, 2014
except for the indentation issues that@stof already mentioned, this is a very big 👍 with even some ❤️ and ✨ (💖) |
rybakit commentedApr 13, 2014
👍 |
mayeco commentedApr 14, 2014
👍 great! |
…ack (fabpot)This PR was merged into the 2.3 branch.Discussion----------Made types used by Symfony compatible with the ones of Hack| Q | A| ------------- | ---| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | n/a| License | MIT| Doc PR | n/aPHP supports several ways to express types: like Boolean/bool or integer/int. Hack only supports one of them, so this PR proposes to use the Hack type to make Symfony a bit more "compatible" with Hack (gradual upgrade ;)).Commits-------3c9c10f made phpdoc types consistent with those defined in Hack0555b7f made types consistent with those defined in Hack
Tobion commentedApr 15, 2014
What do we do about the spaces problem? |
fabpot commentedApr 15, 2014
@Tobion which spaces? |
romainneutron commentedApr 15, 2014
I think@Tobion talks about such spaceshttps://github.com/symfony/symfony/blob/2.3/src/Symfony/Bundle/FrameworkBundle/Controller/RedirectController.php#L77 |
Tobion commentedApr 15, 2014
The phpdoc now has more than 1 space between the type and var name. Not quite consistent with our CS rules. |
romainneutron commentedApr 15, 2014
Well, the issue@stof mentioned in#10701 (comment) is not solved completely (see my previous comment) |
fabpot commentedApr 16, 2014
should be fixed bya693545 |
pyrech commentedApr 16, 2014
It remains extra spaces in phpdoc in lines where the type changed was the longest or the only one |
Tobion commentedApr 16, 2014
I just figured, we should also change the |
fabpot commentedApr 16, 2014
pyrech commentedApr 16, 2014
Some phpdoc are now wrong in the Config component. Have a look ate96b018#diff-d9f16f6d767e4f1a47f5e325d90aa7cfR26 eg:
|
pyrech commentedApr 17, 2014
@fabpot did you see my previous comments? |
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#10750).Discussion----------[Config] fix docblock| Q | A| ------------- | ---| Fixed tickets | none| License | MITSome phpdoc are wrong in the Config component after the PR#10701 was merged.eg: IntegerNode was changed to intNode BooleanNodeDefinition was changed to boolNodeDefinitionCommits-------68debfb fix docblock
This PR was merged into the 2.3 branch.Discussion----------Add a note about which types can be used in Symfony| Q | A| ------------- | ---| Doc fix? | no| New docs? | no| Applies to | all| Fixed tickets | n/aseesymfony/symfony#10701Commits-------bf9d509 added a note about types we support
PHP supports several ways to express types: like Boolean/bool or integer/int. Hack only supports one of them, so this PR proposes to use the Hack type to make Symfony a bit more "compatible" with Hack (gradual upgrade ;)).